Re: [DRAFT PATCH] notmuch new: do not ignore '.notmuch' in non-toplevel directories

diff --git a/15/3efc25c90d0c418d359259199f7a8a66b519ca b/15/3efc25c90d0c418d359259199f7a8a66b519ca
new file mode 100644 (file)
index 0000000..d1d22fe
--- /dev/null
+++ b/15/3efc25c90d0c418d359259199f7a8a66b519ca
@@ -0,0 +1,86 @@
+Return-Path: <rlb@defaultvalue.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 16720431FC3\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Mar 2014 08:22:10 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XP2It1mdbpZt for <notmuch@notmuchmail.org>;\r
+       Sat,  1 Mar 2014 08:22:06 -0800 (PST)\r
+Received: from defaultvalue.org (defaultvalue.org [70.85.129.156])\r
+       by olra.theworths.org (Postfix) with ESMTP id 720C4431FC2\r
+       for <notmuch@notmuchmail.org>; Sat,  1 Mar 2014 08:22:06 -0800 (PST)\r
+Received: from trouble.defaultvalue.org (localhost [127.0.0.1])\r
+       (Authenticated sender: rlb@defaultvalue.org)\r
+       by defaultvalue.org (Postfix) with ESMTPSA id DF98890D2B;\r
+       Sat,  1 Mar 2014 10:22:03 -0600 (CST)\r
+Received: by trouble.defaultvalue.org (Postfix, from userid 1000)\r
+       id 9014E14E14E; Sat,  1 Mar 2014 10:22:03 -0600 (CST)\r
+From: Rob Browning <rlb@defaultvalue.org>\r
+To: Mark Walters <markwalters1009@gmail.com>, Jani Nikula <jani@nikula.org>,\r
+       Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [DRAFT PATCH] notmuch new: do not ignore '.notmuch' in\r
+       non-toplevel directories\r
+In-Reply-To: <87r46mgrxm.fsf@qmul.ac.uk>\r
+References: <87mwhifu9a.fsf@trouble.defaultvalue.org>\r
+       <1393183127-31869-1-git-send-email-tomi.ollila@iki.fi>\r
+       <87ios5v59p.fsf@nikula.org> <87r46mgrxm.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Mar 2014 10:22:03 -0600\r
+Message-ID: <87ha7hvqhg.fsf@trouble.defaultvalue.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Mar 2014 16:22:10 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> An alternative would be to ignore any .notmuch path with a xapian\r
+> sub-directory. This would mean if a user indexed some subset of their\r
+> mail before trying to index the whole thing they wouldn't accidentally\r
+> index the old xapian database. \r
+\r
+If you wanted to be fairly careful, perhaps test for\r
+exists(".notmuch/.xapian/flintlock" or ".notmuch/.xapian/iamchert"), or\r
+some other very specific test.\r
+\r
+> I think the above was suggested by rlb on irc but I don't think it got\r
+> any reply. \r
+\r
+Not sure.  Though I'm wondering if I may have suggested we could add a\r
+notmuch specific token file, i.e. .notmuch/this-really-is-a-notmuch-dir,\r
+which lead to someone else suggesting we could just use .xapian.\r
+\r
+Of course broadly speaking, ".xapian" might be a legitimate maildir too,\r
+but ".notmuch/.xapian" seems fairly unlikely.\r
+\r
+In any case, while I might prefer a very narrow test (as long as it\r
+wasn't unduly expensive), all of the proposed solutions would have\r
+handled my situation.\r
+\r
+Thanks\r
+-- \r
+Rob Browning\r
+rlb @defaultvalue.org and @debian.org\r
+GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A\r
+GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4\r