--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id DD2FF431FC3\r
+ for <notmuch@notmuchmail.org>; Fri, 5 Jul 2013 11:11:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.7\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.7 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id nQ1q41pI1wGJ for <notmuch@notmuchmail.org>;\r
+ Fri, 5 Jul 2013 11:11:27 -0700 (PDT)\r
+Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com\r
+ [209.85.215.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 1ABD0431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 5 Jul 2013 11:11:26 -0700 (PDT)\r
+Received: by mail-ea0-f179.google.com with SMTP id b15so1653545eae.10\r
+ for <notmuch@notmuchmail.org>; Fri, 05 Jul 2013 11:11:24 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:cc:subject:date:message-id:x-mailer;\r
+ bh=FGeebwwnnJzxm5/NZuazHwYMbIhxMhV2LFSgtPv7VzY=;\r
+ b=Yeiw5x0mT1jAtJ3U/ubpnWS3Gb6lMaYjr14dH+UfJC8dBBNnVLkKFnQvV0HjC5nyUX\r
+ AytRO2EPBibLv6syZGiEyaaHJ0+vEcKCejy03CaVL65p/HpjOLEdEbBbWzu1RhiNQypK\r
+ 6AI7XEkaCft92v0YJgtp6rUFEtjzRZNkJc0KLNavWB6wExkoJ8tc6BIxChoWEX12Q/3n\r
+ YsWnans4iVMlp9xC0+42ov+EU8enKTz3e3bkgyPzBF0xW7JJYXeQHdtvOT9mVCHQxkKW\r
+ jDrvc2Z9j0zVKUsec+yMuKLx+0uYeHOo1+dqfMHLhkuigSYKHPliJufMtXxjpj2l9zUs\r
+ UGhg==\r
+X-Received: by 10.14.203.194 with SMTP id f42mr13612898eeo.53.1373047884516;\r
+ Fri, 05 Jul 2013 11:11:24 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+ by mx.google.com with ESMTPSA id i2sm15993446eeu.4.2013.07.05.11.11.23\r
+ for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Fri, 05 Jul 2013 11:11:24 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 00/11] contrib: pick: keybindings\r
+Date: Fri, 5 Jul 2013 19:11:07 +0100\r
+Message-Id: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 05 Jul 2013 18:11:35 -0000\r
+\r
+This series adds lots of keybindings and funtionality to pick: in\r
+particular it adds the stash keymap, the ability to tab between and\r
+activate buttons in the message pane, and it reduces a lot of code\r
+duplication between pick and show.\r
+\r
+It is a large series: but most of it is a lot of small changes. These\r
+small changes are mostly logically independent but as they add\r
+keybindings their contexts all clash. I have made most of the\r
+keybindings as single separate patches to make discussion of them\r
+individually easier.\r
+\r
+The key patches for review/discussion (apart from bike-shedding on\r
+key-bindings!) are patches 1, 5 and 8.\r
+\r
+Patch 1 is the most "controversial": it over-rides\r
+notmuch-show-get-prop so that whether it uses\r
+notmuch-show-get-message-properties or\r
+notmuch-pick-get-message-properties depends on the major-mode (ie\r
+whether it is called from pick or show).\r
+\r
+This means that functions from show which just use message properties\r
+(most often just the message id) "just work" when called from pick. In\r
+particular it gives us access to lots of functions without having to\r
+duplicate the code.\r
+\r
+In the longer term it would be better to have some show/pick common\r
+file and migrate the common functions there.\r
+\r
+Patch 5 and 8 add in functions for creating fucntions ready to be used\r
+in keybindings. The one in patch 5 takes a show fucntion and creates a\r
+function which switches from pick to the message pane, applies the\r
+function and then switches back to pick. The one in patch 8 takes a\r
+function and creates a function which closes the message pane and the\r
+calls this function.\r
+\r
+Both of these make the keybinding section clearer. They also have the\r
+advantage that the user can use them easily to create their own\r
+keybindings which do this.\r
+\r
+This completes all the keybindings I use and I think means that pick\r
+doesn't have any glaring omissions.\r
+\r
+Finally, this will clash with the thread archive patches\r
+id:1371195472-441-1-git-send-email-markwalters1009@gmail.com\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+Mark Walters (11):\r
+ contrib: pick: override notmuch-show-get-prop\r
+ contrib: pick: Link in notmuch-show-pipe-message\r
+ contrib: pick: Link in attachment functions straight from\r
+ notmuch-show\r
+ contrib: pick: Link in stash map straight from notmuch-show\r
+ contrib: pick: add in to-message-window function\r
+ contrib: pick: add button press helper\r
+ contrib: pick: pass tab through to the message pane\r
+ contrib: pick: close window function\r
+ contrib: pick: make help close the message pane first\r
+ contrib: pick: add in binding to view raw message\r
+ contrib: pick: use close-message-pane for reply etc\r
+\r
+ contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++-----------------\r
+ 1 files changed, 70 insertions(+), 69 deletions(-)\r
+\r
+-- \r
+1.7.9.1\r
+\r
projects / notmuch-archives.git / commitdiff