Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

diff --git a/6a/8e87eeea3d1b4cf44c0bf873b90fb049976726 b/6a/8e87eeea3d1b4cf44c0bf873b90fb049976726
new file mode 100644 (file)
index 0000000..ec6dd9f
--- /dev/null
+++ b/6a/8e87eeea3d1b4cf44c0bf873b90fb049976726
@@ -0,0 +1,111 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7CDA1429E5F\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 01:09:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GURif5Ut-t8C for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jan 2012 01:09:55 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 49BBD429E27\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 01:09:55 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+       by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q0I98tVr010590\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:09:53 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by mail-gw3.nixu.fi with ESMTP id 114cs18vmu-1\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT)\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:09:53 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       q0I99q6W006232\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:09:53 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.\r
+In-Reply-To: <cund3aipdr1.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <87pqei327k.fsf@gmail.com>\r
+       <1326809224-22673-1-git-send-email-dme@dme.org>\r
+       <1326809224-22673-2-git-send-email-dme@dme.org>\r
+       <87zkdmwfi7.fsf@gmail.com>\r
+       <cund3aipdr1.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.11+71~gefa5d6c (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 18 Jan 2012 11:09:52 +0200\r
+Message-ID: <yf6wr8p4brz.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211,      0.0.0000        definitions=2012-01-18_04:2012-01-17, 2012-01-18,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       ipscore=0 suspectscore=1\r
+       phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+       reason=mlx\r
+       scancount=1 engine=6.0.2-1012030000 definitions=main-1201180018\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jan 2012 09:09:56 -0000\r
+\r
+On Tue, 17 Jan 2012 15:09:22 +0000, David Edmondson <dme@dme.org> wrote:\r
+> On Tue, 17 Jan 2012 18:49:36 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > > +                # We cannot call 'test_emacs' in a subshell, because\r
+> > > +                # the setting of EMACS_SERVER would not persist\r
+> > > +                # throughout a sequence of tests, so we use a\r
+> > > +                # temporary file.\r
+> > > +                tmp="$TMPDIR"; if [ -z "$tmp" ]; then tmp=/tmp; fi\r
+> > > +                output="$tmp/test_emacs_output.$$"\r
+> > > +                test_emacs "$1" > "${output}"\r
+> > > +                result=$(cat "${output}")\r
+> > > +                rm -f "${output}"\r
+> > \r
+> > I wonder if there is any bash trick which can help here?\r
+> \r
+> I'm not aware of one, but I'm not a bash expert.\r
+\r
+No shell trick possible there.\r
+\r
+> \r
+> > Another option is to start emacs server before using test_emacs in\r
+> > subshell.  See emacs-subject-to-filename for an example.  I think this\r
+> > is a better option than using a temporary file.\r
+> \r
+> I think that's a very poor option. Forcing knowledge the breakage into\r
+> all of the users may make applying any future fix more difficult.\r
+\r
+The alternative would be to replace\r
+emacsclient --socket-name="$EMACS_SERVER" --eval "(progn $@)"\r
+\r
+with something like:\r
+\r
+   case $1 in --stdout-to-output)\r
+       shift\r
+       output=$(emacsclient --socket-name="$EMACS_SERVER" --eval "(progn $@)")\r
+        return\r
+   esac\r
+   emacsclient --socket-name="$EMACS_SERVER" --eval "(progn $@)"\r
+\r
+Tomi\r