Re: [PATCH] emacs: tree/show remove duplicate function

diff --git a/64/e923d34aa90bbcf6f5db2b0038ace8443fa141 b/64/e923d34aa90bbcf6f5db2b0038ace8443fa141
new file mode 100644 (file)
index 0000000..1e50322
--- /dev/null
+++ b/64/e923d34aa90bbcf6f5db2b0038ace8443fa141
@@ -0,0 +1,97 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6184F431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 00:15:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WntroLkq75I9 for <notmuch@notmuchmail.org>;\r
+       Tue, 15 Jul 2014 00:15:07 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AF983431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 00:15:07 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1X6wx7-0005wt-BC; Tue, 15 Jul 2014 08:15:05 +0100\r
+Received: from [194.42.225.51] (helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1X6wx7-0005vz-0K; Tue, 15 Jul 2014 08:15:05 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: tree/show remove duplicate function\r
+In-Reply-To: <87a98bbfab.fsf@maritornes.cs.unb.ca>\r
+References: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com>\r
+       <87a98bbfab.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 15 Jul 2014 08:14:46 +0100\r
+Message-ID: <87zjgbw0t5.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 194.42.225.51\r
+X-QM-Geographic: According to ripencc,\r
+       this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: f364f0d887bda182cce0fdd94454745d (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -0.1 points.\r
+       Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 15 Jul 2014 07:15:14 -0000\r
+\r
+On Tue, 15 Jul 2014, David Bremner <david@tethera.net> wrote:\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>> +              (cond ((eq major-mode 'notmuch-show-mode)\r
+>> +                     (notmuch-show-get-message-properties))\r
+>> +                    ((eq major-mode 'notmuch-tree-mode)\r
+>> +                     (notmuch-tree-get-message-properties))))\r
+>\r
+> I see this already existed, but it looks weird to me to have a two test\r
+> cond with no else. Is it intentional to have the code drop through and\r
+> do nothing if neither case matches?  It seems like it might be better to\r
+> signal an error.\r
+\r
+I can definitely do that. But as a comparison\r
+notmuch-search-get-result and notmuch-search-find-thread-id "work" in\r
+any buffer in the sense of returning nil but not complaining so perhaps\r
+the current version is more consistent. \r
+\r
+Plausibly a comment and an explicit nil case would be clearer for the other modes.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r