--- /dev/null
+Return-Path: <wking@tremily.us>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 11A8B431E64\r
+ for <notmuch@notmuchmail.org>; Mon, 3 Feb 2014 02:55:03 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.625\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.625 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001,\r
+ SUBJ_ALL_CAPS=1.625] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id hmsKK2g8SJWD for <notmuch@notmuchmail.org>;\r
+ Mon, 3 Feb 2014 02:54:56 -0800 (PST)\r
+X-Greylist: delayed 487 seconds by postgrey-1.32 at olra;\r
+ Mon, 03 Feb 2014 02:54:56 PST\r
+Received: from qmta15.westchester.pa.mail.comcast.net\r
+ (qmta15.westchester.pa.mail.comcast.net [76.96.59.228])\r
+ by olra.theworths.org (Postfix) with ESMTP id 6287E431FDB\r
+ for <notmuch@notmuchmail.org>; Mon, 3 Feb 2014 02:54:56 -0800 (PST)\r
+Received: from omta10.westchester.pa.mail.comcast.net ([76.96.62.28])\r
+ by qmta15.westchester.pa.mail.comcast.net with comcast\r
+ id Mml01n0040cZkys5FmmoN5; Mon, 03 Feb 2014 10:46:48 +0000\r
+Received: from odin.tremily.us ([24.18.63.50])\r
+ by omta10.westchester.pa.mail.comcast.net with comcast\r
+ id Mmmm1n00G152l3L3Wmmn6y; Mon, 03 Feb 2014 10:46:48 +0000\r
+Received: from mjolnir.tremily.us (unknown [192.168.0.140])\r
+ by odin.tremily.us (Postfix) with ESMTPS id 37353FB4C69;\r
+ Mon, 3 Feb 2014 02:46:45 -0800 (PST)\r
+Received: (nullmailer pid 31476 invoked by uid 1000);\r
+ Mon, 03 Feb 2014 10:45:48 -0000\r
+From: "W. Trevor King" <wking@tremily.us>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 0/2] \r
+Date: Mon, 3 Feb 2014 02:45:32 -0800\r
+Message-Id: <cover.1391423201.git.wking@tremily.us>\r
+X-Mailer: git-send-email 1.8.5.2.8.g0f6c0d1\r
+In-Reply-To: <877g9chbay.fsf@qmul.ac.uk>\r
+References: <877g9chbay.fsf@qmul.ac.uk>\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
+ s=q20121106; t=1391424408;\r
+ bh=TpnJ9HjpB0UGthm9im+bFc4fZ3bxjNMLDBAnqrYPbhQ=;\r
+ h=Received:Received:Received:Received:From:To:Subject:Date:\r
+ Message-Id;\r
+ b=ehOuuUqui6CedZZFuO6PEfrkriNwAiPiwL85u8eGcyeRR/L2JmnulebCdf7vUK4ZT\r
+ ZYwQN04Xo1WSUIetcw6U5HGfREoPtDSY9eq7wRPwSwTGALFQKcrwY8xt+mBA6Zszrk\r
+ bs2QGBpzqN1tQDQDmw/Mg+UvqXbp842T20dmAxcev9H5ka3m0IccyIed1zaBdODMeY\r
+ 3VX+mmgI2EIghZ8P8KPTCOAQLFyleLDCKkWF0Uu4d6uxop9gWu2IgP4LAUy5l91Q2G\r
+ y9dJprfOtid1ZxNY+GWOy70eBSjy4OErr/u9ItZZlQvLkWK3ZX7wK01cZqWaMpcQZf\r
+ pRPzynCEVOC0A==\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 03 Feb 2014 10:55:03 -0000\r
+\r
+On Mon, Feb 03, 2014 at 08:04:21AM +0000, Mark Walters wrote:\r
+> I think notmuch-show.c gets most of the header and related\r
+> information directly from the mail file not from the database\r
+> directly. I think we use gmime for that parsing so adding an extra\r
+> output pair for content-description there should be\r
+> sufficient. (This is lines 655-700 or so notmuch-show.c)\r
+\r
+Thanks, that's exactly what I needed :).\r
+\r
+> I think the emacs side should be roughly as above: we would need to\r
+> check that the default filename offered when saving is still\r
+> correct.\r
+\r
+notmuch-save-attachments is using:\r
+\r
+ (assq 'filename disposition)\r
+\r
+and it looks like 'name' in notmuch-show-insert-part-header is only\r
+used for the button text.\r
+\r
+> Stylistically I think\r
+> + (name (or (plist-get part :content-description)\r
+> + (plist-get part :filename)))\r
+>\r
+> is a little nicer.\r
+\r
+Thanks for clearing up my search-engine Lisp ;). Fixed in these\r
+patches.\r
+\r
+Cheers,\r
+Trevor\r
+\r
+p.s. I checked a few earlier patches on the list and didn't see\r
+reviewer CCs. On the other hand, I didn't see any Reply-To headers\r
+either, so I'm CCing my reviewers to be safe ;). Let me know if the\r
+convention is to not CC reviewers, and I'll restrict future\r
+submissions to notmuch@.\r
+\r
+W. Trevor King (2):\r
+ notmuch-show: Add content-description output pair\r
+ emacs: Prefer Content-Description over filename for part buttons\r
+\r
+ NEWS | 9 +++\r
+ emacs/notmuch-show.el | 4 +-\r
+ notmuch-show.c | 8 +++\r
+ test/T160-json.sh | 4 +-\r
+ test/T170-sexp.sh | 4 +-\r
+ test/T450-emacs-show.sh | 12 ++++\r
+ test/corpus/cur/24:2, | 1 +\r
+ .../notmuch-show-buttons-content-description | 84 ++++++++++++++++++++++\r
+ .../notmuch-show-buttons-filename | 74 +++++++++++++++++++\r
+ 9 files changed, 195 insertions(+), 5 deletions(-)\r
+ create mode 100644 test/emacs-show.expected-output/notmuch-show-buttons-content-description\r
+ create mode 100644 test/emacs-show.expected-output/notmuch-show-buttons-filename\r
+\r
+-- \r
+1.8.5.2.8.g0f6c0d1\r
+\r
projects / notmuch-archives.git / commitdiff