Re: [notmuch] [PATCH 1/2] Close message file after parsing message headers

diff --git a/9a/6bcb55b5a3d6d4f4b76f2ba268b784a2bf19da b/9a/6bcb55b5a3d6d4f4b76f2ba268b784a2bf19da
new file mode 100644 (file)
index 0000000..aa3a87e
--- /dev/null
+++ b/9a/6bcb55b5a3d6d4f4b76f2ba268b784a2bf19da
@@ -0,0 +1,59 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 59BC3431FBF;\r
+       Wed, 18 Nov 2009 01:42:17 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id j-W1SQlJ7v4j; Wed, 18 Nov 2009 01:42:16 -0800 (PST)\r
+Received: from cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6C6B8431FAE;\r
+       Wed, 18 Nov 2009 01:42:16 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Keith Packard <keithp@keithp.com>, Mikhail Gusarov\r
+       <dottedmag@dottedmag.net>, notmuch@notmuchmail.org\r
+In-Reply-To: <yunbpj0etua.fsf@aiko.keithp.com>\r
+References: <1258471718-6781-1-git-send-email-dottedmag@dottedmag.net>\r
+       <87lji5cbwo.fsf@yoom.home.cworth.org> <yunbpj0etua.fsf@aiko.keithp.com>\r
+Date: Wed, 18 Nov 2009 01:42:02 -0800\r
+Message-ID: <87pr7gqidx.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Subject: Re: [notmuch] [PATCH 1/2] Close message file after parsing message\r
+ headers\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Nov 2009 09:42:17 -0000\r
+\r
+On Tue, 17 Nov 2009 13:15:25 -0800, Keith Packard <keithp@keithp.com> wrote:\r
+> Threading the message also involves displaying the from and to contents,\r
+> which requires opening the message file. The alternative to the fix I\r
+> provided is to just parse all of the message headers when first opening\r
+> the message; it could then be immediately closed and the hash referred\r
+> to for all header data. Given the choice, just having the caller say\r
+> when it has finished with a message is probably a reasonable option...\r
+\r
+Hi Keith,\r
+\r
+Once I finally got back on the ground again, I pushed out a revised\r
+version of your patch, (didn't need the reply-to stuff anymore since I\r
+had fixed that differently in the meantime).\r
+\r
+I'm pretty happy with the state of this portion of the code now.\r
+\r
+Thanks Keith and Mikhail for your input on and code to fix this bug.\r
+\r
+-Carl\r
+\r