Created a bug (wontfix) for Anton Batenev's default-EDITOR comments.

Also fixed a UserError typo in import_xml.py.

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/0922b8f7-b5ce-4572-8e55-c4b34dafe6cf/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/0922b8f7-b5ce-4572-8e55-c4b34dafe6cf/body
new file mode 100644 (file)
index 0000000..991501f
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/0922b8f7-b5ce-4572-8e55-c4b34dafe6cf/body
@@ -0,0 +1,9 @@
+Hello!
+
+--- 8< ---
+$ be comment b35
+ERROR:
+No comment supplied, and EDITOR not specified.
+--- >8 ---
+
+When EDITOR enviroment variable not set try to use vi editor as default editor

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/0922b8f7-b5ce-4572-8e55-c4b34dafe6cf/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/0922b8f7-b5ce-4572-8e55-c4b34dafe6cf/values
new file mode 100644 (file)
index 0000000..d6047ac
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/0922b8f7-b5ce-4572-8e55-c4b34dafe6cf/values
@@ -0,0 +1,11 @@
+Alt-id: <201003161610.10674.antonbatenev@yandex.ru>
+
+
+Author: Anton Batenev <antonbatenev@yandex.ru>
+
+
+Content-type: text/plain
+
+
+Date: Tue, 16 Mar 2010 20:10:10 +0000
+

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/212570d2-8116-462e-9664-9ea8d3976b99/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/212570d2-8116-462e-9664-9ea8d3976b99/body
new file mode 100644 (file)
index 0000000..efebc29
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/212570d2-8116-462e-9664-9ea8d3976b99/body
@@ -0,0 +1 @@
+I agree with Ben.  Setting status to "wontfix".

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/212570d2-8116-462e-9664-9ea8d3976b99/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/212570d2-8116-462e-9664-9ea8d3976b99/values
new file mode 100644 (file)
index 0000000..6abf782
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/212570d2-8116-462e-9664-9ea8d3976b99/values
@@ -0,0 +1,11 @@
+Author: W. Trevor King <wking@drexel.edu>
+
+
+Content-type: text/plain
+
+
+Date: Fri, 19 Mar 2010 06:17:38 +0000
+
+
+In-reply-to: 5e8d490e-ee06-4403-96dd-ad8eac66b21c
+

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/5e8d490e-ee06-4403-96dd-ad8eac66b21c/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/5e8d490e-ee06-4403-96dd-ad8eac66b21c/body
new file mode 100644 (file)
index 0000000..92264a7
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/5e8d490e-ee06-4403-96dd-ad8eac66b21c/body
@@ -0,0 +1,17 @@
+Anton Batenev <antonbatenev@yandex.ru> writes:
+
+> --- 8< ---
+> $ be comment b35
+> ERROR:
+> No comment supplied, and EDITOR not specified.
+> --- >8 ---
+>
+> When EDITOR enviroment variable not set try to use vi editor as
+> default editor
+
+-1. It's up to the local operating system configuration to set a default
+EDITOR value, and up to the user to over-ride that if they want to. An
+application shouldn't be guessing in the absence of those conventions.
+
+The behaviour is clear and the message provides a way for the user to
+rectify the problem in a standard way. It doesn't need to change.

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/5e8d490e-ee06-4403-96dd-ad8eac66b21c/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/5e8d490e-ee06-4403-96dd-ad8eac66b21c/values
new file mode 100644 (file)
index 0000000..17ed58f
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/comments/5e8d490e-ee06-4403-96dd-ad8eac66b21c/values
@@ -0,0 +1,14 @@
+Alt-id: <877hp9w0zy.fsf@benfinney.id.au>
+
+
+Author: Ben Finney <bignose+hates-spam@benfinney.id.au>
+
+
+Content-type: text/plain
+
+
+Date: Fri, 19 Mar 2010 16:31:29 +0000
+
+
+In-reply-to: <201003161610.10674.antonbatenev@yandex.ru>
+

diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/values
new file mode 100644 (file)
index 0000000..79ca1b1
--- /dev/null
+++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/597b03f5-76cb-4951-b370-a01573ad2f75/values
@@ -0,0 +1,17 @@
+creator: W. Trevor King <wking@drexel.edu>
+
+
+reporter: Anton Batenev <abbat@abbat>
+
+
+severity: minor
+
+
+status: wontfix
+
+
+summary: Set a default EDITOR incase the user has not
+
+
+time: Fri, 19 Mar 2010 06:11:12 +0000
+

diff --git a/libbe/command/import_xml.py b/libbe/command/import_xml.py
index 287d8b74a77bf8dbe228e3484304c9fc9414bd64..a8906691edc3a228b868b9920ee914e9e6705a41 100644 (file)
--- a/libbe/command/import_xml.py
+++ b/libbe/command/import_xml.py
@@ -159,7 +159,7 @@ class Import_XML (libbe.command.Command):
         accept_comments = True
         if len(root_comments) > 0:
             if croot_bug == None:
-                raise UserError(
+                raise libbe.command.UserError(
                     '--comment-root option is required for your root comments:\n%s'
                     % '\n\n'.join([c.string() for c in root_comments]))
             try: