Re: [PATCH v2] emacs: Improve the cited message included in replies
authorDavid Edmondson <dme@dme.org>
Mon, 12 May 2014 08:55:07 +0000 (09:55 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:02:43 +0000 (10:02 -0800)
b0/20232e51d10b310a669b54e2efeb19bca94986 [new file with mode: 0644]

diff --git a/b0/20232e51d10b310a669b54e2efeb19bca94986 b/b0/20232e51d10b310a669b54e2efeb19bca94986
new file mode 100644 (file)
index 0000000..7cf43cc
--- /dev/null
@@ -0,0 +1,115 @@
+Return-Path: <dme@dme.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0E46F431FC0\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:55:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2vL-58xIceZ9 for <notmuch@notmuchmail.org>;\r
+       Mon, 12 May 2014 01:55:17 -0700 (PDT)\r
+Received: from mail-we0-f179.google.com (mail-we0-f179.google.com\r
+       [74.125.82.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 97040431FBF\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:55:17 -0700 (PDT)\r
+Received: by mail-we0-f179.google.com with SMTP id q59so6461798wes.38\r
+       for <notmuch@notmuchmail.org>; Mon, 12 May 2014 01:55:16 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
+       :from:date:message-id:mime-version:content-type;\r
+       bh=d8L7F8nXrYrZEZJEO9bdWeyaZIxTa7sT/U4ofziFZpA=;\r
+       b=Dx+Q8Ls4uLqxbi1x6g4zQgmflibVkuzzdZQKiT1awDWFmJje+Y/EzFjGShymTJzGmg\r
+       V7lRjolhFGmm1/ApqP1XKD2Rl1MtnK2FQmQEP/fHCF2bVCOZmWp3+3DMH8nDfAuNHZdR\r
+       NZqyiTxoJlHnypP5HDMCUPsgsny70RMZqDic904a31k3fogtA8lb0D10900a2JEKGCoL\r
+       vqJ8J7gPphUwiekK/j88qq9hgY0YVvuN0/igdt3BGT3uiqHEDAClOisp4BAKOj25PRE2\r
+       a3GXe4CxW8NtSOPe144U/dXLFX0dOFf3eTXMr+F6PccXTu/OgRyH5Y1P4OaCc3xDMnsV\r
+       zGiA==\r
+X-Gm-Message-State:\r
+ ALoCoQlGEwONFbvwJDqf64vYbBiR6fWwUUoUPDG8OXFnFId69MkCBsxifFLq78yp/gUkYT1jr5gr\r
+X-Received: by 10.180.206.205 with SMTP id lq13mr14522143wic.11.1399884915024;\r
+       Mon, 12 May 2014 01:55:15 -0700 (PDT)\r
+Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8])\r
+       by mx.google.com with ESMTPSA id z19sm5923848wiu.0.2014.05.12.01.55.12\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Mon, 12 May 2014 01:55:13 -0700 (PDT)\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: Improve the cited message included in replies\r
+In-Reply-To: <87mwenzaap.fsf@qmul.ac.uk>\r
+References: <1399482846-25308-1-git-send-email-dme@dme.org>\r
+       <1399530272-11857-1-git-send-email-dme@dme.org>\r
+       <87ha4y8286.fsf@qmul.ac.uk>\r
+       <cunzjinbkfr.fsf@hotblack-desiato.hh.sledj.net>\r
+       <87mwenzaap.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+From: David Edmondson <dme@dme.org>\r
+Date: Mon, 12 May 2014 09:55:07 +0100\r
+Message-ID: <cunppjjbclw.fsf@hotblack-desiato.hh.sledj.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 12 May 2014 08:55:21 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+On Mon, May 12 2014, Mark Walters wrote:\r
+>>> Secondly, the existing code only includes text sub-parts of the\r
+>>> message. I would think your version might include any sub-parts show is\r
+>>> configured to display, including, say images. (However, in my testing\r
+>>> images didn't seem to be included: I am not sure why.)\r
+>>\r
+>> Eek.\r
+>\r
+> I phrased this badly. I don't want images included: I just couldn't see\r
+> why they weren't with your current patch (as they are displayed in show\r
+> mode)\r
+\r
+`buffer-substring-no-properties' grabs the text of the rendered buffer\r
+without any properties, and images are inserted using properties.\r
+\r
+You could replace it with `buffer-substring' to see the images in the\r
+reply buffer (but see previous comments about what happens when you\r
+send).\r
+\r
+> I guess my concern with adding to the show code is that is already\r
+> more complicated than I would like (invisibility, hidden parts, lazy\r
+> parts etc).\r
+\r
+One complex piece of code that knows how to iterate over messages\r
+display the parts seems enough - why have two?\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1\r
+\r
+iKYEARECAGYFAlNwjGtfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl\r
+bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5\r
+RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRZ5JACfVOJCSqiGwqDy1Po4l1Es6kXA\r
+h4oAnjn/ZpShpSkC9y8cCMH4fTYKuiop\r
+=DGjg\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r