Re: [PATCH] emacs: call "notmuch tag" only once when archiving a thread

diff --git a/d9/8044c96e8daabc441026964326124d84cacc63 b/d9/8044c96e8daabc441026964326124d84cacc63
new file mode 100644 (file)
index 0000000..c40fe9a
--- /dev/null
+++ b/d9/8044c96e8daabc441026964326124d84cacc63
@@ -0,0 +1,100 @@
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 572F8429E3D\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Jan 2012 06:35:34 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id RIA9t7J1Berd for <notmuch@notmuchmail.org>;\r
+       Wed,  4 Jan 2012 06:35:33 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 83B9D429E21\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Jan 2012 06:35:33 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+       by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id q04EZUPi024411;\r
+       Wed, 4 Jan 2012 16:35:30 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by mail-gw3.nixu.fi with ESMTP id 114cs0xbbm-1\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 04 Jan 2012 16:35:30 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+       by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+       q04EZTUB009265; Wed, 4 Jan 2012 16:35:29 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: call "notmuch tag" only once when archiving a\r
+       thread\r
+In-Reply-To: <1325615346-8302-1-git-send-email-jani@nikula.org>\r
+References: <1325615346-8302-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.10.2+157~g442d405 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 04 Jan 2012 16:35:29 +0200\r
+Message-ID: <yf6wr97y1qm.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211,      0.0.0000        definitions=2012-01-04_06:2012-01-04, 2012-01-04,\r
+       1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+       ipscore=0 suspectscore=0\r
+       phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+       reason=mlx\r
+       scancount=1 engine=6.0.2-1012030000 definitions=main-1201040113\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Jan 2012 14:35:34 -0000\r
+\r
+On Tue,  3 Jan 2012 20:29:06 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> Optimize thread archiving by combining all the -inbox tagging operations to\r
+> a single "notmuch tag" call. Also skip redisplay of tag changes in current\r
+> buffer, as it is immediately killed by the archiving functions.\r
+> \r
+> For threads in the order of tens or a hundred inbox tagged messages, this\r
+> gives a noticeable speedup.\r
+> \r
+> On the downside, IIRC Xapian does not perform very well if the query (in\r
+> this case a lot of message-ids OR'd together) is very big. It is unknown to\r
+> me at which point this approach would become slower than the original one\r
+> by one tagging approach, if ever.\r
+> \r
+> Also, this introduces a limitation to the number of messages that can be\r
+> archived at the same time (through ARG_MAX limiting the command line). At\r
+> least on Linux this seems more like a theoretical limitation than a real\r
+> one.\r
+\r
+IIRC some systems have like 32768 byte command line limit.\r
+If the change did tagging in like 100-message batches then this limit is\r
+hardly exceeded (if message-id's max 80 characters then command line is\r
+8000+ bytes)...\r
+Hmm -- is there a length limit for message-id. If not maybe when appending \r
+message id's keep counting length and tag in batches based on that lenght\r
+value.\r
+\r
+Hundreds of messages per tagging operation instead of one is good\r
+improvements.\r
+\r
+> Signed-off-by: Jani Nikula <jani@nikula.org>\r
+\r
+Tomi\r