Re: [PATCH] Avoid empty thread names if possible.

diff --git a/a5/466d2533521b534fe02333e3499d101742456a b/a5/466d2533521b534fe02333e3499d101742456a
new file mode 100644 (file)
index 0000000..28be834
--- /dev/null
+++ b/a5/466d2533521b534fe02333e3499d101742456a
@@ -0,0 +1,59 @@
+Return-Path: <prvs=372b3579b=jrosenthal@jhu.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8E8F7431FC2\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 06:07:42 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 06TKoHFkN6X5 for <notmuch@notmuchmail.org>;\r
+       Wed, 29 Oct 2014 06:07:37 -0700 (PDT)\r
+Received: from smtpauth.johnshopkins.edu (smtpauth.johnshopkins.edu\r
+       [162.129.8.200]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9E62C431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 06:07:37 -0700 (PDT)\r
+X-IronPort-AV: E=Sophos;i="5.04,809,1406606400"; d="scan'208";a="437386008"\r
+Received: from guppy.hwcampus.jhu.edu (HELO localhost) ([10.161.32.234])\r
+       by ipex1.johnshopkins.edu with ESMTP/TLS/AES128-SHA;\r
+       29 Oct 2014 09:07:32 -0400\r
+From: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Avoid empty thread names if possible.\r
+In-Reply-To: <87tx2nuvec.fsf@qmul.ac.uk>\r
+References: <87oatnakqy.fsf@jhu.edu> <87tx2nuvec.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18.2+155~gafa8535 (http://notmuchmail.org) Emacs/24.4.1\r
+       (i686-pc-linux-gnu)\r
+Date: Wed, 29 Oct 2014 09:07:32 -0400\r
+Message-ID: <87a94f2fe3.fsf@jhu.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Oct 2014 13:07:42 -0000\r
+\r
+By the way, this discussion brings up another problem. I wasn't able to\r
+write a test for this (to address the below concerns) because the test\r
+suite for thread-naming supplies some sort of auto-generated subject\r
+for threads with empty subjects. So we can't test behavior for dealing\r
+with empty subjects.\r
+\r
+Unfortunately, I don't know the history of the test suite, or why this\r
+auto-subject decisicion was made, so I don't feel comfortable just\r
+changing the behavior.\r