Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message

diff --git a/a9/6c15d64e6912684de330435c1e5a277e0227c5 b/a9/6c15d64e6912684de330435c1e5a277e0227c5
new file mode 100644 (file)
index 0000000..b81c0f3
--- /dev/null
+++ b/a9/6c15d64e6912684de330435c1e5a277e0227c5
@@ -0,0 +1,78 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 03A16431FBC\r
+       for <notmuch@notmuchmail.org>; Mon,  6 Oct 2014 06:25:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id H0G0NqVMORpg for <notmuch@notmuchmail.org>;\r
+       Mon,  6 Oct 2014 06:25:20 -0700 (PDT)\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5C975431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  6 Oct 2014 06:25:20 -0700 (PDT)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+       by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+       (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+       id 1Xb8Ht-0004OY-8x; Mon, 06 Oct 2014 09:25:17 -0400\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+       (envelope-from <aclements@csail.mit.edu>)\r
+       id 1Xb8Hs-0000P3-FC; Mon, 06 Oct 2014 09:25:16 -0400\r
+Date: Mon, 6 Oct 2014 09:25:16 -0400\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message\r
+Message-ID: <20141006132516.GF7970@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+       <1412345958-8278-3-git-send-email-aclements@csail.mit.edu>\r
+       <87k34fot7d.fsf@maritornes.cs.unb.ca>\r
+       <20141005232008.GB7970@csail.mit.edu>\r
+       <871tqlpwcx.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <871tqlpwcx.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Mutt/1.5.23 (2014-03-12)\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 06 Oct 2014 13:25:26 -0000\r
+\r
+Quoth David Bremner on Oct 06 at  8:04 am:\r
+> Austin Clements <aclements@csail.mit.edu> writes:\r
+> \r
+> > Quoth David Bremner on Oct 05 at  9:45 am:\r
+> >> Austin Clements <aclements@csail.mit.edu> writes:\r
+> >> > +    void *local = talloc_new (NULL);\r
+> >> \r
+> >> What's the advantage of using a local talloc context here? Is this just\r
+> >> an optimization?\r
+> >\r
+> > There are a few allocations that wind up going in to this local\r
+> > context because of the call to _consume_metadata_thread_id, so it's\r
+> > more convenient to free this one context on return from\r
+> > _notmuch_database_link_message than to worry about tracking these\r
+> > various allocations.\r
+> \r
+> OK, but wouldn't the lazy solution be to use message as a talloc\r
+> context?\r
+\r
+That would be the lazy solution, but it would also leak a bunch of\r
+allocations that don't need to live past the end of\r
+_notmuch_database_link_message.\r