Re: [PATCH 2/2] cli: define config getters and setters using a macro

diff --git a/e4/686120b09af537605f5127a5d4c2c7f39bacf0 b/e4/686120b09af537605f5127a5d4c2c7f39bacf0
new file mode 100644 (file)
index 0000000..6cf7869
--- /dev/null
+++ b/e4/686120b09af537605f5127a5d4c2c7f39bacf0
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7B4EB431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 05:29:33 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id mz2P3iGp736n for <notmuch@notmuchmail.org>;\r
+       Wed, 15 Jan 2014 05:29:28 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 69362431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 05:29:28 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1W3QX9-0005hM-N9; Wed, 15 Jan 2014 09:29:27 -0400\r
+Received: (nullmailer pid 24903 invoked by uid 1000); Wed, 15 Jan 2014\r
+       13:29:24 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/2] cli: define config getters and setters using a macro\r
+In-Reply-To: <1376839205-5115-2-git-send-email-jani@nikula.org>\r
+References: <1376839205-5115-1-git-send-email-jani@nikula.org>\r
+       <1376839205-5115-2-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 15 Jan 2014 09:29:24 -0400\r
+Message-ID: <87y52hidaj.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 15 Jan 2014 13:29:33 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> There's plenty of duplicated code in defining the functions for config\r
+> get/set. Add macros to define the functions.\r
+>\r
+> ---\r
+>\r
+> This might be a bit too tricky for some people's tastes... let's see!\r
+> ;)\r
+\r
+I could go either way on this. I don't find it unbearably tricky; I'm\r
+also not 100% sure it's needed. But if you and Tomi still like the idea,\r
+I'm ok with it.\r
+\r
+d\r