--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0A2A2431FBC\r
+ for <notmuch@notmuchmail.org>; Sat, 6 Sep 2014 06:35:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 2vkJ5eYmkch4 for <notmuch@notmuchmail.org>;\r
+ Sat, 6 Sep 2014 06:35:32 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 90464431FB6\r
+ for <notmuch@notmuchmail.org>; Sat, 6 Sep 2014 06:35:32 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XQG90-000444-30; Sat, 06 Sep 2014 14:35:30 +0100\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XQG8z-000296-NT; Sat, 06 Sep 2014 14:35:09 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/3] cli: add --output=address-{from, to,\r
+ all} to notmuch search\r
+In-Reply-To: <1410008010-3770-2-git-send-email-jani@nikula.org>\r
+References: <1410008010-3770-1-git-send-email-jani@nikula.org>\r
+ <1410008010-3770-2-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 06 Sep 2014 14:35:08 +0100\r
+Message-ID: <871troub1v.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: fe3629b9ec387ce245e5d00924c2010d (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 06 Sep 2014 13:35:41 -0000\r
+\r
+On Sat, 06 Sep 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> address-from prints reply-to or from, address-to prints to, cc, and\r
+> bcc, and address-all prints all of them.\r
+\r
+Hi\r
+\r
+I like these: thanks a lot for doing this. \r
+\r
+Just one quick comment before I do an actual review:\r
+\r
+> ---\r
+> notmuch-search.c | 113 ++++++++++++++++++++++++++++++++++++++++++++++++++-----\r
+> 1 file changed, 104 insertions(+), 9 deletions(-)\r
+>\r
+> diff --git a/notmuch-search.c b/notmuch-search.c\r
+> index bc9be4593ecc..c84ecc31262c 100644\r
+> --- a/notmuch-search.c\r
+> +++ b/notmuch-search.c\r
+> @@ -23,11 +23,14 @@\r
+> #include "string-util.h"\r
+> \r
+> typedef enum {\r
+> - OUTPUT_SUMMARY,\r
+> - OUTPUT_THREADS,\r
+> - OUTPUT_MESSAGES,\r
+> - OUTPUT_FILES,\r
+> - OUTPUT_TAGS\r
+> + OUTPUT_SUMMARY = 1 << 0,\r
+> + OUTPUT_THREADS = 1 << 1,\r
+> + OUTPUT_MESSAGES = 1 << 2,\r
+> + OUTPUT_FILES = 1 << 3,\r
+> + OUTPUT_TAGS = 1 << 4,\r
+> + OUTPUT_ADDRESS_FROM = 1 << 5,\r
+> + OUTPUT_ADDRESS_TO = 1 << 6,\r
+> + OUTPUT_ADDRESS_ALL = OUTPUT_ADDRESS_FROM | OUTPUT_ADDRESS_TO,\r
+> } output_t;\r
+> \r
+> /* Return two stable query strings that identify exactly the matched\r
+> @@ -214,6 +217,66 @@ do_search_threads (sprinter_t *format,\r
+> return 0;\r
+> }\r
+> \r
+> +static void\r
+> +print_address_list (sprinter_t *format, InternetAddressList *list)\r
+> +{\r
+> + InternetAddress *address;\r
+> + int i;\r
+> +\r
+> + for (i = 0; i < internet_address_list_length (list); i++) {\r
+> + address = internet_address_list_get_address (list, i);\r
+> + if (INTERNET_ADDRESS_IS_GROUP (address)) {\r
+> + InternetAddressGroup *group;\r
+> + InternetAddressList *group_list;\r
+> +\r
+> + group = INTERNET_ADDRESS_GROUP (address);\r
+> + group_list = internet_address_group_get_members (group);\r
+> + if (group_list == NULL)\r
+> + continue;\r
+> +\r
+> + print_address_list (format, group_list);\r
+> + } else {\r
+> + InternetAddressMailbox *mailbox;\r
+> + const char *name;\r
+> + const char *addr;\r
+> + char *full_address;\r
+> +\r
+> + mailbox = INTERNET_ADDRESS_MAILBOX (address);\r
+> +\r
+> + name = internet_address_get_name (address);\r
+> + addr = internet_address_mailbox_get_addr (mailbox);\r
+> +\r
+> + if (name && *name)\r
+> + full_address = talloc_asprintf (NULL, "%s <%s>", name, addr);\r
+> + else\r
+> + full_address = talloc_asprintf (NULL, "<%s>", addr);\r
+> +\r
+> + if (!full_address)\r
+> + break;\r
+> +\r
+> + format->string (format, full_address);\r
+> + format->separator (format);\r
+> +\r
+> + talloc_free (full_address);\r
+> + }\r
+> + }\r
+> +}\r
+> +\r
+> +static void\r
+> +print_address_string (sprinter_t *format, const char *recipients)\r
+> +{\r
+> + InternetAddressList *list;\r
+> +\r
+> + if (recipients == NULL)\r
+> + return;\r
+> +\r
+> + list = internet_address_list_parse_string (recipients);\r
+> + if (list == NULL)\r
+> + return;\r
+> +\r
+> + print_address_list (format, list);\r
+> +}\r
+> +\r
+> static int\r
+> do_search_messages (sprinter_t *format,\r
+> notmuch_query_t *query,\r
+> @@ -264,11 +327,33 @@ do_search_messages (sprinter_t *format,\r
+> \r
+> notmuch_filenames_destroy( filenames );\r
+> \r
+> - } else { /* output == OUTPUT_MESSAGES */\r
+> + } else if (output == OUTPUT_MESSAGES) {\r
+> format->set_prefix (format, "id");\r
+> format->string (format,\r
+> notmuch_message_get_message_id (message));\r
+> format->separator (format);\r
+> + } else {\r
+> + if (output & OUTPUT_ADDRESS_FROM) {\r
+> + const char *addrs;\r
+> +\r
+> + addrs = notmuch_message_get_header (message, "reply-to");\r
+> +\r
+> + if (addrs == NULL || *addrs == '\0')\r
+> + addrs = notmuch_message_get_header (message, "from");\r
+\r
+I would suggest adding a separate address-reply-to option. The main\r
+reason is that we store from in the database so if you do from without\r
+the reply-to it is *very* fast whereas with the reply-to notmuch has to\r
+read every message to get the reply-to header. Even on a fully hot cache\r
+this means that from alone is a factor of 10 faster than reply-to/from.\r
+\r
+(If anyone wants to test this themselves just comment out the reply-to\r
+and if lines above)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> +\r
+> + print_address_string (format, addrs);\r
+> + }\r
+> +\r
+> + if (output & OUTPUT_ADDRESS_TO) {\r
+> + const char *hdrs[] = { "to", "cc", "bcc" };\r
+> + const char *addrs;\r
+> + size_t j;\r
+> +\r
+> + for (j = 0; j < ARRAY_SIZE (hdrs); j++) {\r
+> + addrs = notmuch_message_get_header (message, hdrs[j]);\r
+> + print_address_string (format, addrs);\r
+> + }\r
+> + }\r
+> }\r
+> \r
+> notmuch_message_destroy (message);\r
+> @@ -338,7 +423,7 @@ notmuch_search_command (notmuch_config_t *config, int argc, char *argv[])\r
+> notmuch_sort_t sort = NOTMUCH_SORT_NEWEST_FIRST;\r
+> sprinter_t *format = NULL;\r
+> int opt_index, ret;\r
+> - output_t output = OUTPUT_SUMMARY;\r
+> + output_t output = 0;\r
+> int offset = 0;\r
+> int limit = -1; /* unlimited */\r
+> notmuch_exclude_t exclude = NOTMUCH_EXCLUDE_TRUE;\r
+> @@ -364,10 +449,12 @@ notmuch_search_command (notmuch_config_t *config, int argc, char *argv[])\r
+> { "text0", NOTMUCH_FORMAT_TEXT0 },\r
+> { 0, 0 } } },\r
+> { NOTMUCH_OPT_INT, ¬much_format_version, "format-version", 0, 0 },\r
+> - { NOTMUCH_OPT_KEYWORD, &output, "output", 'o',\r
+> + { NOTMUCH_OPT_KEYWORD_FLAGS, &output, "output", 'o',\r
+> (notmuch_keyword_t []){ { "summary", OUTPUT_SUMMARY },\r
+> { "threads", OUTPUT_THREADS },\r
+> { "messages", OUTPUT_MESSAGES },\r
+> + { "address-from", OUTPUT_ADDRESS_FROM },\r
+> + { "address-to", OUTPUT_ADDRESS_TO },\r
+> { "files", OUTPUT_FILES },\r
+> { "tags", OUTPUT_TAGS },\r
+> { 0, 0 } } },\r
+> @@ -387,6 +474,9 @@ notmuch_search_command (notmuch_config_t *config, int argc, char *argv[])\r
+> if (opt_index < 0)\r
+> return EXIT_FAILURE;\r
+> \r
+> + if (! output)\r
+> + output = OUTPUT_SUMMARY;\r
+> +\r
+> switch (format_sel) {\r
+> case NOTMUCH_FORMAT_TEXT:\r
+> format = sprinter_text_create (config, stdout);\r
+> @@ -453,18 +543,23 @@ notmuch_search_command (notmuch_config_t *config, int argc, char *argv[])\r
+> }\r
+> \r
+> switch (output) {\r
+> - default:\r
+> case OUTPUT_SUMMARY:\r
+> case OUTPUT_THREADS:\r
+> ret = do_search_threads (format, query, sort, output, offset, limit);\r
+> break;\r
+> case OUTPUT_MESSAGES:\r
+> + case OUTPUT_ADDRESS_FROM:\r
+> + case OUTPUT_ADDRESS_TO:\r
+> + case OUTPUT_ADDRESS_ALL:\r
+> case OUTPUT_FILES:\r
+> ret = do_search_messages (format, query, output, offset, limit, dupe);\r
+> break;\r
+> case OUTPUT_TAGS:\r
+> ret = do_search_tags (notmuch, format, query);\r
+> break;\r
+> + default:\r
+> + fprintf (stderr, "Error: the combination of outputs is not supported.\n");\r
+> + ret = 1;\r
+> }\r
+> \r
+> notmuch_query_destroy (query);\r
+> -- \r
+> 2.1.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff