Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch address results

diff --git a/3f/8b9f6f3a499534f1d564a1dce9d3a90f66afa3 b/3f/8b9f6f3a499534f1d564a1dce9d3a90f66afa3
new file mode 100644 (file)
index 0000000..578c4b3
--- /dev/null
+++ b/3f/8b9f6f3a499534f1d564a1dce9d3a90f66afa3
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 4DA5C6DE00CB\r
+ for <notmuch@notmuchmail.org>; Sat, 29 Aug 2015 18:31:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.118\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.118 tagged_above=-999 required=5 tests=[AWL=0.118]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id RnBGhOQ5KsSE for <notmuch@notmuchmail.org>;\r
+ Sat, 29 Aug 2015 18:31:56 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 226F76DE005F\r
+ for <notmuch@notmuchmail.org>; Sat, 29 Aug 2015 18:31:55 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ZVrRf-0005Rn-Hd; Sun, 30 Aug 2015 01:30:07 +0000\r
+Received: (nullmailer pid 18833 invoked by uid 1000); Sun, 30 Aug 2015\r
+ 01:29:46 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch\r
+ address results\r
+In-Reply-To:\r
+ <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org>\r
+References: <cover.1440859765.git.jani@nikula.org>\r
+ <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 29 Aug 2015 22:29:46 -0300\r
+Message-ID: <87d1y5tvg5.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Aug 2015 01:31:58 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+\r
+> +    { NOTMUCH_OPT_KEYWORD, &ctx->dupe, "deduplicate", 'x',\r
+\r
+probably you want 'D' or 'd' here. Not that it makes a practical\r
+difference at this point.\r
+\r
+> +      (notmuch_keyword_t []){ { "yes", -1 },\r
+\r
+I'm not very enthusiastic about reusing ctx->dupe for this.\r
+In particular the use of -1 for yes is off-putting\r
+It seems better to allocate another word of memory and use an\r
+enum, as elsewhere.\r