Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

diff --git a/53/80e2b2f40f151acb258752b6e1b1572a203638 b/53/80e2b2f40f151acb258752b6e1b1572a203638
new file mode 100644 (file)
index 0000000..16adf9b
--- /dev/null
+++ b/53/80e2b2f40f151acb258752b6e1b1572a203638
@@ -0,0 +1,76 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 78846431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 10:34:33 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Pk+9GqXTn9q7 for <notmuch@notmuchmail.org>;\r
+       Sat, 25 Jan 2014 10:34:28 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BA06C431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 10:34:28 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1W783l-0003Qy-KZ; Sat, 25 Jan 2014 14:34:25 -0400\r
+Received: (nullmailer pid 3574 invoked by uid 1000); Sat, 25 Jan 2014\r
+       18:34:22 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el\r
+In-Reply-To: <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>\r
+References: <87y5sipcjn.fsf@qmul.ac.uk>\r
+       <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.17+42~gb867564 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 25 Jan 2014 14:34:22 -0400\r
+Message-ID: <87bnyzoqq9.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 25 Jan 2014 18:34:33 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> ido-completing-read is used in notmuch-mua.el without any\r
+> initialization.  This should work but a bug (emacs bug #3247) in some\r
+> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs\r
+> to get stuck in the mini-buffer. This tests to see if ido-mode has\r
+> been initialized and if not calls it. This avoids the bug for these\r
+> older versions of emacs.\r
+>\r
+> This is the only place that ido-completing-read is used so an alternative \r
+> would be to replace ido-completing-read by completing-read but cworth \r
+> expressed a preference for the ido version in \r
+> id:"87wrhfvk6a.fsf@yoom.home.cworth.\r
+\r
+This patch was tagged wip, but then there was no progress ;).  It still\r
+applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor\r
+emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can\r
+confirm it actually fixes the bug there.\r
+\r
+I propose we either apply the patch or ::wontfix the bug.\r
+\r
+cheers,\r
+\r
+d\r