Add TODO note about support for blocks within slots. Thanks to Brian Harring for...
authorZac Medico <zmedico@gentoo.org>
Sat, 12 May 2007 23:14:19 +0000 (23:14 -0000)
committerZac Medico <zmedico@gentoo.org>
Sat, 12 May 2007 23:14:19 +0000 (23:14 -0000)
svn path=/main/trunk/; revision=6524

pym/emerge/__init__.py

index 4d3f32e76015420b8e86618ae9468b9c116ce468..e6d2d8236987e798a0c914cb951658fa41251dae 100644 (file)
@@ -1915,10 +1915,10 @@ class depgraph:
                                for cpv in blocked_initial:
                                        slot_atom = blocked_slots_initial[cpv]
                                        if slot_atom == pslot_atom:
-                                               # The parent blocks an initial package in the same
-                                               # slot as itself.  The merge/nomerge status of neither
-                                               # node matters.  In any case, this particular block is
-                                               # automatically resolved.
+                                               # TODO: Support blocks within slots in cases where it
+                                               # might make sense.  For example, a new version might
+                                               # require that the old version be uninstalled at build
+                                               # time.
                                                continue
                                        if parent_static and \
                                                slot_atom not in modified_slots[myroot]:
@@ -1942,8 +1942,7 @@ class depgraph:
                                for cpv in blocked_final:
                                        slot_atom = blocked_slots_final[cpv]
                                        if slot_atom == pslot_atom:
-                                               # The parent blocks itself, so the merge order does not
-                                               # need to be enforced.
+                                               # TODO: Support blocks within slots.
                                                continue
                                        if parent_static and \
                                                slot_atom not in modified_slots[myroot]: