--- /dev/null
+Return-Path: <tassilo@member.fsf.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 88426431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 00:13:18 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Ekmpx5sBe3kC for <notmuch@notmuchmail.org>;\r
+ Fri, 27 Nov 2009 00:13:16 -0800 (PST)\r
+Received: from out4.smtp.messagingengine.com (out4.smtp.messagingengine.com\r
+ [66.111.4.28])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8E96B431FBC\r
+ for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 00:13:16 -0800 (PST)\r
+Received: from compute1.internal (compute1.internal [10.202.2.41])\r
+ by gateway1.messagingengine.com (Postfix) with ESMTP id 2726FC1EB5;\r
+ Fri, 27 Nov 2009 03:13:16 -0500 (EST)\r
+Received: from heartbeat1.messagingengine.com ([10.202.2.160])\r
+ by compute1.internal (MEProxy); Fri, 27 Nov 2009 03:13:16 -0500\r
+DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com;\r
+ h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=smtpout; bh=ZonpsFkW+Dq3y7Oe7FCURx6AuJI=;\r
+ b=tWTCrqU9Kbifoe8YWCfuIx0HRrnCFYsVQQZpozHSF5HS3dvHaI0oRFeAngkQ9oMApe85I00F7KFwGAY7IB7mB00nyfQyV4zJGchXQnllmx+CJ8nBY/eLKX8QAAfVi71789QVTe/YpNOcou07s3WqOnifo8wywFhc2i6rA/LXyts=\r
+X-Sasl-enc: CkOcIJgB3aEXE/xu33zZE2we3WKn2APfPeGTE9ycyWf9 1259309595\r
+Received: from thinkpad.tsdh.de (p54AF2603.dip0.t-ipconnect.de [84.175.38.3])\r
+ by mail.messagingengine.com (Postfix) with ESMTPA id F03EE39AE06;\r
+ Fri, 27 Nov 2009 03:13:14 -0500 (EST)\r
+From: Tassilo Horn <tassilo@member.fsf.org>\r
+To: Carl Worth <cworth@cworth.org>\r
+In-Reply-To: <87k4xdq7ys.fsf@yoom.home.cworth.org> (Carl Worth's message of\r
+ "Thu, 26 Nov 2009 13:42:03 -0800")\r
+References: <87tywlji10.fsf@thinkpad.tsdh.de>\r
+ <87k4xdq7ys.fsf@yoom.home.cworth.org>\r
+User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux)\r
+Date: Fri, 27 Nov 2009 09:13:12 +0100\r
+Message-ID: <87d4349yhz.fsf@thinkpad.tsdh.de>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: [notmuch] [PATCH] Return unpropertized strings for filename and\r
+ message-id\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 27 Nov 2009 08:13:18 -0000\r
+\r
+Carl Worth <cworth@cworth.org> writes:\r
+\r
+Hi Carl,\r
+\r
+>> Here's my first patch. It changes that notmuch-show-get-filename and\r
+>> notmuch-show-get-message-id return simple strings and not propertited\r
+>> strings.\r
+>\r
+> Thanks, Tassilo!\r
+>\r
+> It's great to have a contribution from you in notmuch. I've pushed\r
+> this out now.\r
+\r
+I guess it won't be the last one. There are some byte-compiler warnings\r
+with notmuch.el, that I'd like to remove.\r
+\r
+> Two things with regards to your patch:\r
+>\r
+> 1. It's most convenient (for me) to apply emailed patches by sending\r
+> directly to "git am". And "git am" just happens to want to see the\r
+> complete commit message as the first thing in the mail message,\r
+> (continuing the summary of the commit which comes from the\r
+> subject).\r
+>\r
+> So to satisfy "git am", introductory and explanatory portions of\r
+> the email, ("Hi!" and "Here's my first patch"), have to be\r
+> relegated to past the "---" divider).\r
+\r
+So an email looking like this would be correct?\r
+\r
+--8<---------------cut here---------------start------------->8---\r
+From: Tassilo Horn <tassilo@member.fsf.org>\r
+To: Carl Worth <cworth@cworth.org>\r
+Cc: notmuch@notmuchmail.org\r
+Date: Fri, 27 Nov 2009 08:54:41 +0100\r
+Subject: [PATCH] Remove preprocessor code\r
+\r
+Don't define RUNNING_ON_VALGRIND, so that notmuch is probably broken.\r
+---\r
+ debugger.c | 2 --\r
+ 1 files changed, 0 insertions(+), 2 deletions(-)\r
+\r
+diff --git a/debugger.c b/debugger.c\r
+index e8b9378..f32cdc9 100644\r
+--- a/debugger.c\r
++++ b/debugger.c\r
+@@ -24,8 +24,6 @@\r
+ \r
+ #if HAVE_VALGRIND\r
+ #include <valgrind.h>\r
+-#else\r
+-#define RUNNING_ON_VALGRIND 0\r
+ #endif\r
+ \r
+ notmuch_bool_t\r
+-- \r
+1.6.5.3\r
+\r
+Hi Carl,\r
+\r
+this patch is completely wrong. Please don't apply it. :-)\r
+\r
+And thanks again for the great work.\r
+\r
+Bye,\r
+Tassilo\r
+--8<---------------cut here---------------end--------------->8---\r
+\r
+> 2. Maybe I'll undermine my point above, but the commit here really\r
+> *does* need a commit message beyond the first line.\r
+>\r
+> I've described this before as the one-line summary giving the\r
+> "what" and the rest of the commit message giving the "why".\r
+\r
+Makes sense.\r
+\r
+> And this is a perfect case of that. I can see exactly what the\r
+> patch does, and it makes sense. But I tried to write the rest of\r
+> the commit message and found I couldn't. In what cases did the\r
+> presence of text properties cause a problem? I don't know, and\r
+> that's what the commit message should have said.\r
+\r
+Normally it causes almost never any problems, but IMO it's just bad\r
+style. When a user wants to get the Message-id, he most probably only\r
+wants to do some calculations on that (e.g. jump to that message in Gnus\r
+or rmail), or insert it somewhere else. In the first case, text\r
+properties aren't needed, and in the second case, it's most unlikely\r
+that he wants to have exactly the same properties there, especially if\r
+there are properties different from faces.\r
+\r
+> I'd said before that I would bounce patches with only a one-line\r
+> summary. I guess I'm still too soft, but do expect me to be more\r
+> strict on this in the future. :-)\r
+\r
+Yes, that all makes perfect sense, and because there are so many people\r
+and patches for notmuch (which is great!), there have to be some strict\r
+guidelines.\r
+\r
+But instead of mailing each first-time committer a mail, you might\r
+consider putting those guidelines on the notmuch homepage. :-)\r
+\r
+Bye,\r
+Tassilo\r
projects / notmuch-archives.git / commitdiff