Re: [PATCH v2] lib: make notmuch shared library install_name be full path on Mac...

diff --git a/10/86ca39e571b07b43a5b9e079ed901651b05ee6 b/10/86ca39e571b07b43a5b9e079ed901651b05ee6
new file mode 100644 (file)
index 0000000..ab50e91
--- /dev/null
+++ b/10/86ca39e571b07b43a5b9e079ed901651b05ee6
@@ -0,0 +1,95 @@
+Return-Path: <jinwoo68@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 12CDD431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Mar 2015 14:40:44 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.639\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.639 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_ENVFROM_END_DIGIT=1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5+7DcVR5J7pN for <notmuch@notmuchmail.org>;\r
+       Wed,  4 Mar 2015 14:40:40 -0800 (PST)\r
+Received: from mail-ie0-f175.google.com (mail-ie0-f175.google.com\r
+       [209.85.223.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C0EB4431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  4 Mar 2015 14:40:40 -0800 (PST)\r
+Received: by iecat20 with SMTP id at20so18088322iec.6\r
+       for <notmuch@notmuchmail.org>; Wed, 04 Mar 2015 14:39:47 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+       :mime-version:content-type;\r
+       bh=vxyyIZ64lfFzwwzlJreY3QF9N49KhF9WbPiKK8ugtlA=;\r
+       b=Km+0eUp3oQlNp+JyMPb+HTv6M4s7G2gI3VEKvPgBj/gMSunSdJ7lnaBTc241/r2weL\r
+       ftPE4IH2cipZV7GmGQ1CcgGuYslHT9oEyzBzBx9t3yQ7vYqCO6OGweLsKr/aTeEMinMG\r
+       mY8ssz1SCP4EcNITjWSH2s9cNpVogDb2CCI8DCcJMej0zyrrMitM6ZuKQ6E0Po46K9jE\r
+       3vloAqvQiNmHuL9G1pvvtqwP1YAyhy2fMV9J5ucFmrduPjy5YOxqKH8g+joAqmk5HmD/\r
+       22d9fTHjBzOt4jbB9KIZbu9ci/dfShF4sTadupHhLtEwJgoxoDtD0///DTAmFVgWA67e\r
+       vehA==\r
+X-Received: by 10.107.164.221 with SMTP id d90mr16160054ioj.13.1425508786921; \r
+       Wed, 04 Mar 2015 14:39:46 -0800 (PST)\r
+Received: from localhost ([2620:0:1000:407c:94fb:a3ba:4a7f:aa53])\r
+       by mx.google.com with ESMTPSA id 192sm3710920ioo.38.2015.03.04.14.39.45\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Wed, 04 Mar 2015 14:39:45 -0800 (PST)\r
+From: Jinwoo Lee <jinwoo68@gmail.com>\r
+To: "J. Lewis Muir" <jlmuir@imca-cat.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] lib: make notmuch shared library install_name be full\r
+       path    on Mac OS X\r
+In-Reply-To: <1425508369-28448-1-git-send-email-jlmuir@imca-cat.org>\r
+References: <1425508369-28448-1-git-send-email-jlmuir@imca-cat.org>\r
+User-Agent: Notmuch/0.19+67~g326e188 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-apple-darwin13.2.0)\r
+Date: Wed, 04 Mar 2015 14:39:44 -0800\r
+Message-ID: <yq65egp44cb3.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Mar 2015 22:40:44 -0000\r
+\r
+On Wed, Mar  4, 2015 at 02:32 PM, "J. Lewis Muir" <jlmuir@imca-cat.org> wrote:\r
+> The install_name of libnotmuch.dylib on Mac OS X is what is written\r
+> into a program that links against it.  If it is just the name of the\r
+> shared library file, as opposed to the full path, the program won't be\r
+> able to find it when it runs and will abort.  Instead, the install_name\r
+> should be the full path to the shared library (in its final installed\r
+> location).\r
+\r
+Thanks for this fix!  I built notmuch last night on my mac using the\r
+prefix of "/opt/local", and it revealed this problem.  Manually moving\r
+libnotmuch.dylib to $HOME/lib fixed it.  I'll try again once this patch\r
+is checked in.\r
+\r
+>\r
+> Why does Notmuch work without this patch when installed via Homebrew?\r
+> The answer is twofold.  One, /usr/local/lib is a special location in\r
+> which the dynamic linker will look by default to find shared libraries.\r
+> Homebrew highly recommends installing to /usr/local, and, assuming it\r
+> has been configured this way, the Notmuch library will end up installed\r
+> in /usr/local/lib, and the dynamic linker will find it.  Two, Homebrew\r
+> globally corrects all install names in dynamically shared libraries and\r
+> binaries for each package it installs.  So, even if the install names in\r
+> a package's binaries and libraries are incorrect, Homebrew corrects them\r
+> automatically, and no one ever knows.\r
+>\r
+> Why does Notmuch work without this patch when installed via MacPorts?\r
+> The answer is that MacPorts applies a patch just like this patch to fix\r
+> the same problem.\r