Re: [PATCH] test: use test_expect_equal for PATH test, update message

diff --git a/6c/8939dcc27e04cca7ccf87aa94bb004fd174ad5 b/6c/8939dcc27e04cca7ccf87aa94bb004fd174ad5
new file mode 100644 (file)
index 0000000..b987579
--- /dev/null
+++ b/6c/8939dcc27e04cca7ccf87aa94bb004fd174ad5
@@ -0,0 +1,96 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2AD8F431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Apr 2014 05:49:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id D+GHuE2nmOX3 for <notmuch@notmuchmail.org>;\r
+       Sun, 13 Apr 2014 05:49:13 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id A4E2B431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Apr 2014 05:49:13 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 2304310008F;\r
+       Sun, 13 Apr 2014 15:49:07 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: use test_expect_equal for PATH test, update message\r
+In-Reply-To: <1397392969-8735-1-git-send-email-david@tethera.net>\r
+References: <1397392969-8735-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.17+184~g85e3db6 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 13 Apr 2014 15:49:06 +0300\r
+Message-ID: <m2ha5xv1h9.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Apr 2014 12:49:22 -0000\r
+\r
+On Sun, Apr 13 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> - The old test was quite impossible to debug; the new one shows the difference\r
+>   between the two directories, if any.\r
+>\r
+> - "repository" doesn't make sense for out of tree builds. Or tarball\r
+>   builds, for that matter.\r
+> ---\r
+\r
+Looks better than the old one. +1\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> I was tracking down a weird issue with out of tree builds. I didn't\r
+> find the issue (it may have just been cruft from a previously broken\r
+> build). In any case, I think the patch is a small improvement.\r
+>\r
+>  test/T000-basic.sh | 7 ++++---\r
+>  1 file changed, 4 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/test/T000-basic.sh b/test/T000-basic.sh\r
+> index 9c94b62..ebbb6d2 100755\r
+> --- a/test/T000-basic.sh\r
+> +++ b/test/T000-basic.sh\r
+> @@ -86,8 +86,9 @@ test_expect_success \\r
+>      'NOTMUCH_CONFIG is set and points to an existing file' \\r
+>      'test -f "${NOTMUCH_CONFIG}"'\r
+>  \r
+> -test_expect_success \\r
+> -    'PATH is set to this repository' \\r
+> -    'test "`echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,'`" = "`dirname ${TEST_DIRECTORY}`"'\r
+> +test_begin_subtest 'PATH is set to build directory'\r
+> +test_expect_equal \\r
+> +    "$(dirname ${TEST_DIRECTORY})" \\r
+> +    "$(echo $PATH|cut -f1 -d: | sed -e 's,/test/valgrind/bin$,,')"\r
+>  \r
+>  test_done\r
+> -- \r
+> 1.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r