Re: [PATCH v2 1/3] contrib: pick: if no target specified go to first matching message

diff --git a/2e/baae8e02d07c730a5989db35848563653b54ab b/2e/baae8e02d07c730a5989db35848563653b54ab
new file mode 100644 (file)
index 0000000..780840b
--- /dev/null
+++ b/2e/baae8e02d07c730a5989db35848563653b54ab
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A3536431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:06:09 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Q3qb0iJ5v6MP for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Jun 2013 09:06:03 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8144B431FC2\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 09:06:03 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UtK8Z-0003Gi-1M; Sun, 30 Jun 2013 13:06:03 -0300\r
+Received: (nullmailer pid 13322 invoked by uid 1000); Sun, 30 Jun 2013\r
+       16:05:59 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/3] contrib: pick: if no target specified go to first\r
+       matching message\r
+In-Reply-To: <1372582512-10777-2-git-send-email-markwalters1009@gmail.com>\r
+References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com>\r
+       <1372582512-10777-2-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 30 Jun 2013 13:05:59 -0300\r
+Message-ID: <87obantwgo.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Jun 2013 16:06:09 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+> -  (let ((msg-id (notmuch-id-to-query (plist-get msg :id))))\r
+> -    (when (string= msg-id notmuch-pick-target-msg)\r
+> +  (let ((msg-id (notmuch-id-to-query (plist-get msg :id)))\r
+> +    (target notmuch-pick-target-msg))\r
+> +    (when (or (and (not target) (plist-get msg :match))\r
+> +          (string= msg-id target))\r
+\r
+I can't really figure out from looking at the code what this 'target'\r
+business is about. Possibly unrelated to this patch, but maybe some\r
+documentation is needed?\r
+\r
+d\r