[PATCH v2 11/11] contrib: pick: use close-message-pane for reply etc
authorMark Walters <markwalters1009@gmail.com>
Sun, 18 Aug 2013 12:14:39 +0000 (13:14 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:56:25 +0000 (09:56 -0800)
14/d6c84ebf0e52040247effea58630e5fe246efe [new file with mode: 0644]

diff --git a/14/d6c84ebf0e52040247effea58630e5fe246efe b/14/d6c84ebf0e52040247effea58630e5fe246efe
new file mode 100644 (file)
index 0000000..c59fb17
--- /dev/null
@@ -0,0 +1,139 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id AB9AC431FDB\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Aug 2013 05:15:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id yzfyqp8iz9S6 for <notmuch@notmuchmail.org>;\r
+       Sun, 18 Aug 2013 05:15:43 -0700 (PDT)\r
+Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com\r
+       [209.85.212.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id BFD44431FD2\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Aug 2013 05:15:04 -0700 (PDT)\r
+Received: by mail-wi0-f173.google.com with SMTP id en1so2205685wid.0\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Aug 2013 05:15:03 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:in-reply-to:references;\r
+       bh=eQM61RPlpLPmhcPwhimCL8lYgyUQdz8zvy0f6tasc50=;\r
+       b=kimyMQ+h34tJ+U/vpNtGLVfDcbPJ+oD1wEJYsUkqsJ2UVyt0gY8JpE98LmjHwPKMDp\r
+       vDkVwDlF/C0FMIdsj7n6LsD4969rFvOplWTMKH63oa9P26KCvpKMm2Cz0jIIM8Ev4VFd\r
+       4hXUmEe6Hgss3QDUyvZ48DHaceTTtENVmrv+C6/5GukXPQwvnkStC5dH9re/omyD9MXb\r
+       zxVihaJbKulqBhn/dg7xg+4mbCj6if2mEzdDTUu0ZHGj0QmJ/fbiOGWyQwgvnfhdo3AF\r
+       93Xcs4xIzLKO8RjXiXoQ4clhyHN2nO0PmyMm6BvS562ozcc7a9lGLaxLNTxcnBQa2wfN\r
+       R6gA==\r
+X-Received: by 10.180.74.134 with SMTP id t6mr4486418wiv.56.1376828103644;\r
+       Sun, 18 Aug 2013 05:15:03 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+       by mx.google.com with ESMTPSA id jf2sm9084554wic.2.1969.12.31.16.00.00\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sun, 18 Aug 2013 05:15:03 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 11/11] contrib: pick: use close-message-pane for reply etc\r
+Date: Sun, 18 Aug 2013 13:14:39 +0100\r
+Message-Id: <1376828079-21455-12-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+In-Reply-To: <1376828079-21455-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1376828079-21455-1-git-send-email-markwalters1009@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 18 Aug 2013 12:15:47 -0000\r
+\r
+We can save some code duplication by using the new close-message-pane\r
+functionality for reply, forward, and new mail.\r
+---\r
+ contrib/notmuch-pick/notmuch-pick.el |   43 +++------------------------------\r
+ 1 files changed, 4 insertions(+), 39 deletions(-)\r
+\r
+diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+index 0e10c7c..3b86a5a 100644\r
+--- a/contrib/notmuch-pick/notmuch-pick.el\r
++++ b/contrib/notmuch-pick/notmuch-pick.el\r
+@@ -236,6 +236,10 @@ FUNC."\r
+     (define-key map "e" (notmuch-pick-to-message-pane #'notmuch-pick-button-activate))\r
\r
+     ;; bindings from show (or elsewhere) but we close the message pane first.\r
++    (define-key map "m" (notmuch-pick-close-message-pane-and #'notmuch-mua-new-mail))\r
++    (define-key map "f" (notmuch-pick-close-message-pane-and #'notmuch-show-forward-message))\r
++    (define-key map "r" (notmuch-pick-close-message-pane-and #'notmuch-show-reply-sender))\r
++    (define-key map "R" (notmuch-pick-close-message-pane-and #'notmuch-show-reply))\r
+     (define-key map "V" (notmuch-pick-close-message-pane-and #'notmuch-show-view-raw-message))\r
+     (define-key map "?" (notmuch-pick-close-message-pane-and #'notmuch-help))\r
\r
+@@ -246,10 +250,6 @@ FUNC."\r
+     (define-key map "=" 'notmuch-pick-refresh-view)\r
+     (define-key map "s" 'notmuch-pick-to-search)\r
+     (define-key map "z" 'notmuch-pick-to-pick)\r
+-    (define-key map "m" 'notmuch-pick-new-mail)\r
+-    (define-key map "f" 'notmuch-pick-forward-message)\r
+-    (define-key map "r" 'notmuch-pick-reply-sender)\r
+-    (define-key map "R" 'notmuch-pick-reply)\r
+     (define-key map "n" 'notmuch-pick-next-matching-message)\r
+     (define-key map "p" 'notmuch-pick-prev-matching-message)\r
+     (define-key map "N" 'notmuch-pick-next-message)\r
+@@ -599,41 +599,6 @@ message will be \"unarchived\", i.e. the tag changes in\r
+                        target\r
+                        (get-buffer buffer-name))))\r
\r
+-(defmacro with-current-notmuch-pick-message (&rest body)\r
+-  "Evaluate body with current buffer set to the text of current message"\r
+-  `(save-excursion\r
+-     (let ((id (notmuch-pick-get-message-id)))\r
+-       (let ((buf (generate-new-buffer (concat "*notmuch-msg-" id "*"))))\r
+-         (with-current-buffer buf\r
+-          (call-process notmuch-command nil t nil "show" "--format=raw" id)\r
+-           ,@body)\r
+-       (kill-buffer buf)))))\r
+-\r
+-(defun notmuch-pick-new-mail (&optional prompt-for-sender)\r
+-  "Compose new mail."\r
+-  (interactive "P")\r
+-  (notmuch-pick-close-message-window)\r
+-  (notmuch-mua-new-mail prompt-for-sender ))\r
+-\r
+-(defun notmuch-pick-forward-message (&optional prompt-for-sender)\r
+-  "Forward the current message."\r
+-  (interactive "P")\r
+-  (notmuch-pick-close-message-window)\r
+-  (with-current-notmuch-pick-message\r
+-   (notmuch-mua-new-forward-message prompt-for-sender)))\r
+-\r
+-(defun notmuch-pick-reply (&optional prompt-for-sender)\r
+-  "Reply to the sender and all recipients of the current message."\r
+-  (interactive "P")\r
+-  (notmuch-pick-close-message-window)\r
+-  (notmuch-mua-new-reply (notmuch-pick-get-message-id) prompt-for-sender t))\r
+-\r
+-(defun notmuch-pick-reply-sender (&optional prompt-for-sender)\r
+-  "Reply to the sender of the current message."\r
+-  (interactive "P")\r
+-  (notmuch-pick-close-message-window)\r
+-  (notmuch-mua-new-reply (notmuch-pick-get-message-id) prompt-for-sender nil))\r
+-\r
+ (defun notmuch-pick-clean-address (address)\r
+   "Try to clean a single email ADDRESS for display. Return\r
+ AUTHOR_NAME if present, otherwise return AUTHOR_EMAIL. Return\r
+-- \r
+1.7.9.1\r
+\r