Re: [PATCH 0/4] configure: fix some shellcheck warnings

diff --git a/e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7 b/e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7
new file mode 100644 (file)
index 0000000..9e59a9d
--- /dev/null
+++ b/e8/d65b3a9d3a2972a9e1d3c73b4ac704a3f785c7
@@ -0,0 +1,99 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 5531A6DE024A\r
+ for <notmuch@notmuchmail.org>; Wed, 27 Apr 2016 11:14:25 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.608\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.608 tagged_above=-999 required=5 tests=[AWL=-0.044,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id RZdCQp69-wb1 for <notmuch@notmuchmail.org>;\r
+ Wed, 27 Apr 2016 11:14:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 1AECD6DE01D0\r
+ for <notmuch@notmuchmail.org>; Wed, 27 Apr 2016 11:14:17 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id E571E100063;\r
+ Wed, 27 Apr 2016 21:14:12 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/4] configure: fix some shellcheck warnings\r
+In-Reply-To: <cover.1460572142.git.jani@nikula.org>\r
+References: <cover.1460572142.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.22+7~g2ab49fe (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 27 Apr 2016 21:14:12 +0300\r
+Message-ID: <m24mamx6kr.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 27 Apr 2016 18:14:25 -0000\r
+\r
+On Wed, Apr 13 2016, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> TIL about shellcheck [1]. Played with it a bit. Seems useful.\r
+>\r
+> $ shellcheck --exclude 2086 --shell sh configure\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+> [1] http://www.shellcheck.net/\r
+>\r
+>\r
+> Jani Nikula (4):\r
+\r
+This series looks tolerable to me, with a slight change in first commit msg:\r
+\r
+>   configure: SC2006: Use $(..) instead of deprecated `..`\r
+\r
+This is what older shellcheck outputs, but newer has fixed this to be\r
+\r
+   configure: SC2006: Use $(..) instead of legacy `..`\r
+\r
+When testing in http://www.shellcheck.net/\r
+\r
+Line 1:\r
+foo=`echo x`\r
+^-- SC2034: foo appears unused. Verify it or export it.\r
+    ^-- SC2006: Use $(..) instead of legacy `..`.\r
+    ^-- SC2116: Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd\r
+    foo'.\r
+\r
+This is the shellcheck commit (s/deprecated/legacy/ for backtick warnings.):\r
+\r
+https://github.com/koalaman/shellcheck/commit/895d83afc5f4dec7dc9813a2688c45b96d6f7b7c\r
+\r
+based on these I suggest commit message amend before pushing (?)\r
+\r
+Tomi\r
+\r
+\r
+>   configure: SC2059: Don't use variables in the printf format string.\r
+>   configure: SC2034: glib_cflags and glib_ldflags appear unused.\r
+>   configure: SC2016: Expressions don't expand in single quotes\r
+>\r
+>  configure | 25 +++++++++++++------------\r
+>  1 file changed, 13 insertions(+), 12 deletions(-)\r
+>\r
+> -- \r
+> 2.1.4\r