Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of notmuch_database_close

diff --git a/40/8abef608e06521aeb533005d99b35c426cd414 b/40/8abef608e06521aeb533005d99b35c426cd414
new file mode 100644 (file)
index 0000000..5415998
--- /dev/null
+++ b/40/8abef608e06521aeb533005d99b35c426cd414
@@ -0,0 +1,103 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id ECA5F431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Apr 2012 06:39:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id lIVRXqNIArZ7 for <notmuch@notmuchmail.org>;\r
+       Wed, 25 Apr 2012 06:39:34 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU\r
+       [18.9.25.15])\r
+       by olra.theworths.org (Postfix) with ESMTP id 59F9E431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 25 Apr 2012 06:39:34 -0700 (PDT)\r
+X-AuditID: 1209190f-b7f8a6d000000914-d2-4f97fe95d406\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id EC.0F.02324.59EF79F4; Wed, 25 Apr 2012 09:39:33 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q3PDdWej024970; \r
+       Wed, 25 Apr 2012 09:39:32 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3PDdU1F009304\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 25 Apr 2012 09:39:31 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SN2RO-0001gp-Nr; Wed, 25 Apr 2012 09:39:30 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Justus Winter <4winter@informatik.uni-hamburg.de>,\r
+       Felipe Contreras <felipe.contreras@gmail.com>\r
+Subject: Re: [PATCH 6/7] ruby: Use notmuch_database_destroy instead of\r
+       notmuch_database_close\r
+In-Reply-To: <20120423124946.31231.53523@thinkbox.jade-hamburg.de>\r
+References: <20120422120620.26225.40778@thinkbox.jade-hamburg.de>\r
+       <1335096477-27537-1-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <1335096477-27537-6-git-send-email-4winter@informatik.uni-hamburg.de>\r
+       <CAMP44s0KHJz6AxUfRjEUk5heOEFVyT2NixpFNb5GZakXaoLAKw@mail.gmail.com>\r
+       <20120423124946.31231.53523@thinkbox.jade-hamburg.de>\r
+User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Wed, 25 Apr 2012 09:39:30 -0400\r
+Message-ID: <87obqggcbx.fsf@awakening.csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsUixCmqrDv133R/gxcrLSxmt/5gsjj4OM/i\r
+       +s2ZzA7MHjtn3WX3mHj+NJvHs1W3mAOYo7hsUlJzMstSi/TtErgyFr45wF7wir1i35X3zA2M\r
+       i9m6GDk5JARMJCbc/cYCYYtJXLi3HiwuJLCPUWLvxKIuRi4gewOjxMvWL2wQzkkmiSUrvrJC\r
+       OEsYJT4tXwXWwiagIbFt/3JGEFtEIFfi6eRWJhCbWUBa4tvvZjBbWCBW4v/lC8wgNqeAk8SO\r
+       9+9YIAadYJKY+W0WWLOoQLzEn97NYENZBFQlOu82gjXzAt365Go/I4QtKHFy5hMWiAVaEjf+\r
+       vWSawCg4C0lqFpLUAkamVYyyKblVurmJmTnFqcm6xcmJeXmpRbomermZJXqpKaWbGMHhK8m/\r
+       g/HbQaVDjAIcjEo8vLP3TvMXYk0sK67MPcQoycGkJMp7+Nd0fyG+pPyUyozE4oz4otKc1OJD\r
+       jBIczEoivC9eAuV4UxIrq1KL8mFS0hwsSuK8alrv/IQE0hNLUrNTUwtSi2CyMhwcShK8V/8C\r
+       NQoWpaanVqRl5pQgpJk4OEGG8wAN/whSw1tckJhbnJkOkT/FqCglzrsJJCEAksgozYPrhaWX\r
+       V4ziQK8I8+4BqeIBpia47ldAg5mABn8LmgYyuCQRISXVwBhy9IuALcOHRcmB124sfD3RksPQ\r
+       Ocl1y5wM8cyXR4onJV5Wiz9/ykHT9aFQYK6D/ZMLbcz7l1hVqanb2Nb9vs/7+WqI3JZv17nT\r
+       9RO7nG/lJ36uFsv+UMifX3qU/V2YxBrNhT6MO3qsU0vSFCYHhJk56rYVffJ7PJ3nmlWI1KFF\r
+       p9209h4JVWIpzkg01GIuKk4EAO904YcKAwAA\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 25 Apr 2012 13:39:35 -0000\r
+\r
+On Mon, 23 Apr 2012, Justus Winter <4winter@informatik.uni-hamburg.de> wrote:\r
+> Quoting Felipe Contreras (2012-04-23 14:36:33)\r
+>> I don't think this is the right approach. If database_destroy truly\r
+>> destroys the object, then we would want to do it only at garbage\r
+>> collection, when it's not accessible any more. What if I want to\r
+>> re-use the database from the Ruby code?\r
+>> \r
+>> This would probably be better:\r
+>> \r
+>>[...]\r
+>\r
+> You're probably right, I don't know the ruby bindings at all, I just\r
+> wanted to preserve the old behavior. You are welcome to refine the\r
+> ruby bindings later (or maintain them, I *believe* they are\r
+> unmaintained, the last change was back in october 2011), but let's get\r
+> this patch series in first.\r
+\r
+I just marked this series ready, but I wasn't clear on what the\r
+conclusion here was.  Feel free to mark it moreinfo again if it's not\r
+actually ready (maybe mark just this patch?  it's a bit confusing since\r
+the patches aren't quite all together.)\r