Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available

diff --git a/8e/c5c65137c013734b05d8f94fe39a1ea0e5e5f2 b/8e/c5c65137c013734b05d8f94fe39a1ea0e5e5f2
new file mode 100644 (file)
index 0000000..04c2458
--- /dev/null
+++ b/8e/c5c65137c013734b05d8f94fe39a1ea0e5e5f2
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 559686DE0BF6\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 23:16:50 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.642\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.642 tagged_above=-999 required=5 tests=[AWL=-0.010,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id SxnurhfVVeIB for <notmuch@notmuchmail.org>;\r
+ Wed, 10 Feb 2016 23:16:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id EF79F6DE0B36\r
+ for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 23:16:47 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 16ACE10007F;\r
+ Thu, 11 Feb 2016 09:17:00 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v3 06/16] Prefer gpg2 in the test suite if available\r
+In-Reply-To: <874mdgo6za.fsf@alice.fifthhorseman.net>\r
+References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1454272801-23623-7-git-send-email-dkg@fifthhorseman.net>\r
+ <87lh6svl0b.fsf@maritornes.cs.unb.ca>\r
+ <874mdgo6za.fsf@alice.fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 11 Feb 2016 09:16:59 +0200\r
+Message-ID: <m237szk978.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 11 Feb 2016 07:16:50 -0000\r
+\r
+On Wed, Feb 10 2016, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:\r
+\r
+> On Wed 2016-02-10 06:54:12 -0500, David Bremner wrote:\r
+>> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+>>\r
+>>>  \r
+>>> +# choose the preferred GnuPG binary:\r
+>>> +if command -v gpg2 > /dev/null; then\r
+>>> +    GPG=gpg2\r
+>>> +else\r
+>>> +    GPG=gpg\r
+>>> +fi\r
+>>\r
+>> It feels like this should maybe be in configure, to centralize the choice\r
+>> of GPG default. At least, that would be consistent with python / python2\r
+>\r
+> I'm not sure what to do here.  Ultimately, i don't want there to be a\r
+> choice because i plan on having /usr/bin/gpg provided by gpg2, so this\r
+> will all be moot.\r
+\r
+Code searches through PATH, so IMO this test could do the same (with\r
+reasonable similarity (like above)). This could add check whether GPG\r
+is already defined that definition is used...\r
+\r
+\r
+>\r
+> So i'm not inclined to spend much more time/engineering effort on it,\r
+> but if someone wants to propose moving these choices into configure, i'd\r
+> be willing to review.\r
+>\r
+>    --dkg\r