Re: [PATCH] use notmuch_database_open_verbose

diff --git a/48/bd29c0acb2a98e97cae57e9a112b0bbb4a9e62 b/48/bd29c0acb2a98e97cae57e9a112b0bbb4a9e62
new file mode 100644 (file)
index 0000000..8a4a001
--- /dev/null
+++ b/48/bd29c0acb2a98e97cae57e9a112b0bbb4a9e62
@@ -0,0 +1,83 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 40AB46DE1867\r
+ for <notmuch@notmuchmail.org>; Sat, 12 Mar 2016 08:26:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.031\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5\r
+ tests=[AWL=-0.020, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id GaVv7M2tK7dc for <notmuch@notmuchmail.org>;\r
+ Sat, 12 Mar 2016 08:26:49 -0800 (PST)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 5F20A6DE1865\r
+ for <notmuch@notmuchmail.org>; Sat, 12 Mar 2016 08:26:49 -0800 (PST)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1aemNw-0007qq-Ba; Sat, 12 Mar 2016 11:27:24 -0500\r
+Received: (nullmailer pid 29846 invoked by uid 1000);\r
+ Sat, 12 Mar 2016 16:26:45 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Patrick Totzke <patricktotzke@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] use notmuch_database_open_verbose\r
+In-Reply-To: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com>\r
+References: <1457795857-12410-1-git-send-email-patricktotzke@gmail.com>\r
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 12 Mar 2016 12:26:45 -0400\r
+Message-ID: <87r3ff64sa.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 12 Mar 2016 16:26:51 -0000\r
+\r
+Patrick Totzke <patricktotzke@gmail.com> writes:\r
+\r
+> ... instead of the deprecated notmuch_database_open\r
+\r
+Perhaps it should be formally deprecated, but unlike several other\r
+functions, it isn't.\r
+\r
+> when opening the database in notmuch.database.Database.open.\r
+> This prevents the library to print Xapian exceptions to stderr.\r
+> ---\r
+>  bindings/python/notmuch/database.py | 6 +++---\r
+>  1 file changed, 3 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py\r
+> index f304533..5400338 100644\r
+> --- a/bindings/python/notmuch/database.py\r
+> +++ b/bindings/python/notmuch/database.py\r
+> @@ -86,8 +86,8 @@ class Database(object):\r
+>      _get_version.argtypes = [NotmuchDatabaseP]\r
+>      _get_version.restype = c_uint\r
+>  \r
+> -    """notmuch_database_open"""\r
+> -    _open = nmlib.notmuch_database_open\r
+> +    """notmuch_database_open_verbose"""\r
+> +    _open = nmlib.notmuch_database_open_verbose\r
+>      _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]\r
+>      _open.restype = c_uint\r
+\r
+I expect you probably want to add the new binding, rather than replacing\r
+the old one. Otherwise updating the bindings will break all bindings\r
+using scripts.\r
+\r
+d\r