Re: [notmuch] [PATCH] notmuch-show: add tags to json output

diff --git a/55/4e2e4f49762e6e86c3b4ed47e4f5da0c0ac444 b/55/4e2e4f49762e6e86c3b4ed47e4f5da0c0ac444
new file mode 100644 (file)
index 0000000..66f4749
--- /dev/null
+++ b/55/4e2e4f49762e6e86c3b4ed47e4f5da0c0ac444
@@ -0,0 +1,71 @@
+Return-Path: <bremner@pivot.cs.unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C2F62431FC3\r
+       for <notmuch@notmuchmail.org>; Mon,  1 Mar 2010 09:30:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.568\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.568 tagged_above=-999 required=5 tests=[AWL=0.172,\r
+       BAYES_20=-0.74] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fqUEuvJE+nrV for <notmuch@notmuchmail.org>;\r
+       Mon,  1 Mar 2010 09:30:14 -0800 (PST)\r
+Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3BC41431FBD\r
+       for <notmuch@notmuchmail.org>; Mon,  1 Mar 2010 09:30:14 -0800 (PST)\r
+Received: from\r
+       fctnnbsc30w-142167166109.pppoe-dynamic.high-speed.nb.bellaliant.net\r
+       ([142.167.166.109] helo=rocinante.cs.unb.ca)\r
+       by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.69) (envelope-from <bremner@pivot.cs.unb.ca>)\r
+       id 1Nm9RV-0004zG-3B; Mon, 01 Mar 2010 13:30:05 -0400\r
+Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.71)\r
+       (envelope-from <bremner@rocinante.cs.unb.ca>)\r
+       id 1Nm9OO-0006yW-GY; Mon, 01 Mar 2010 13:26:52 -0400\r
+From: David Bremner <bremner@unb.ca>\r
+To: Sebastian Spaeth <Sebastian@SSpaeth.de>, notmuch@notmuchmail.org\r
+In-Reply-To: <1267457946-30347-1-git-send-email-Sebastian@SSpaeth.de>\r
+References: <87r5o49kow.fsf@SSpaeth.de>\r
+       <1267457946-30347-1-git-send-email-Sebastian@SSpaeth.de>\r
+Date: Mon, 01 Mar 2010 13:26:52 -0400\r
+Message-ID: <878wacrm03.fsf@rocinante.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Verified: bremner@pivot.cs.unb.ca\r
+Subject: Re: [notmuch] [PATCH] notmuch-show: add tags to json output\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 01 Mar 2010 17:30:14 -0000\r
+\r
+On Mon,  1 Mar 2010 16:39:06 +0100, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:\r
+> The previous json patches forgot to add the notmuch tags to the json\r
+> output. This is inconsistent to the text output so here they are. We\r
+> just output a 'tags' field that sends a space delimited list of\r
+> json-encoded notmuch tags.\r
+> \r
+> Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>\r
+\r
+I agree we need tags in json output, but I think that making the client\r
+parse the string of (space delimited?) tags defeats a bit the purpose of\r
+having json output.  What do you think about \r
+\r
+       "tags": [ "inbox", "unread" ] \r
+\r
+instead of \r
+\r
+        "tags": "inbox unread"\r
+\r