Re: [PATCH] cli: cast timeval fields to long for format
authorTomi Ollila <tomi.ollila@iki.fi>
Tue, 28 Oct 2014 09:33:02 +0000 (11:33 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:05:44 +0000 (10:05 -0800)
ff/92d564d62df14f89e6b439f8ec8446a67a0a9a [new file with mode: 0644]

diff --git a/ff/92d564d62df14f89e6b439f8ec8446a67a0a9a b/ff/92d564d62df14f89e6b439f8ec8446a67a0a9a
new file mode 100644 (file)
index 0000000..60bf0fd
--- /dev/null
@@ -0,0 +1,82 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 720AB431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 02:33:27 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Gh-56zaVc-Dc for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Oct 2014 02:33:19 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 45E96431FAE\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Oct 2014 02:33:19 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 3F7B2100051;\r
+       Tue, 28 Oct 2014 11:33:02 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] cli: cast timeval fields to long for format\r
+In-Reply-To: <1414484246-19659-1-git-send-email-jani@nikula.org>\r
+References: <1414484246-19659-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 28 Oct 2014 11:33:02 +0200\r
+Message-ID: <m28uk0tu7l.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 28 Oct 2014 09:33:27 -0000\r
+\r
+On Tue, Oct 28 2014, Jani Nikula <jani@nikula.org> wrote:\r
+\r
+> This hides platform differences between struct timeval field types.\r
+\r
+LGTM.\r
+\r
+Tomi\r
+\r
+> ---\r
+>  notmuch-insert.c |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/notmuch-insert.c b/notmuch-insert.c\r
+> index 7074077..0d2d810 100644\r
+> --- a/notmuch-insert.c\r
+> +++ b/notmuch-insert.c\r
+> @@ -197,7 +197,7 @@ tempfilename (const void *ctx)\r
+>      gettimeofday (&tv, NULL);\r
+>  \r
+>      filename = talloc_asprintf (ctx, "%ld.M%ldP%d.%s",\r
+> -                            tv.tv_sec, tv.tv_usec, pid, hostname);\r
+> +                            (long) tv.tv_sec, (long) tv.tv_usec, pid, hostname);\r
+>      if (! filename)\r
+>      fprintf (stderr, "Error: %s\n", strerror (ENOMEM));\r
+>  \r
+> -- \r
+> 1.7.2.5\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r