Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3) implementation.

diff --git a/07/566d58ed3de905acd5a6093cb7b2a5852125aa b/07/566d58ed3de905acd5a6093cb7b2a5852125aa
new file mode 100644 (file)
index 0000000..cbde04b
--- /dev/null
+++ b/07/566d58ed3de905acd5a6093cb7b2a5852125aa
@@ -0,0 +1,86 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3410D431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 16:55:53 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id JwRrVQn2cr4p for <notmuch@notmuchmail.org>;\r
+       Sat, 25 Jan 2014 16:55:47 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 13197431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 16:55:47 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1W7E0h-0005FY-6B; Sat, 25 Jan 2014 20:55:39 -0400\r
+Received: (nullmailer pid 24358 invoked by uid 1000); Sun, 26 Jan 2014\r
+       00:55:35 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH] configure: check for POSIX.1-2008 realpath(3)\r
+       implementation.\r
+In-Reply-To: <1390687142-16401-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1390687142-16401-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.17+42~gb867564 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 25 Jan 2014 20:55:35 -0400\r
+Message-ID: <871tzvo92w.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 26 Jan 2014 00:55:53 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+> +#if POSIX_2008_REALPATH\r
+>      filename = realpath (config->filename, NULL);\r
+> +#else\r
+> +    /* compatibility with minor effort, not elegance, is the ruling factor\r
+> +       in these (two) else branches... */\r
+> +    char resolved_path[PATH_MAX];\r
+> +    filename = realpath (config->filename, resolved_path);\r
+> +#endif\r
+>      if (! filename) {\r
+>      if (errno == ENOENT) {\r
+> +#if POSIX_2008_REALPATH\r
+>          filename = strdup (config->filename);\r
+> +#else\r
+> +        /* ... this is the other else... */\r
+> +        resolved_path[sizeof resolved_path - 1] = '\0';\r
+> +        strncpy(resolved_path, config->filename, sizeof resolved_path);\r
+> +        /* "faking" out of memory in case path too long -- close enough? */\r
+> +        filename = resolved_path[sizeof resolved_path - 1]?\r
+> +            resolved_path: NULL;\r
+> +#endif\r
+\r
+I worry a bit about making the mainline code messier and harder to maintain, in order to\r
+accomodate an unknown number of targets without POSIX2008 realpath. Do\r
+we know how widespread this problem is? Is it just NetBSD?\r
+\r
+I looked at borrowing realpath from gnulib; it looks like it would be a\r
+bit of work as the least complicated version includes 3 other include\r
+files. But then the mainline code could be blisfully ignorant of the\r
+whole dispute.\r
+\r
+d\r
+\r