Re: [PATCH] Index Content-Type of attachments with a contenttype prefix

diff --git a/70/9c59413dc640ba54ac0a8f616be35817008300 b/70/9c59413dc640ba54ac0a8f616be35817008300
new file mode 100644 (file)
index 0000000..3dc3b70
--- /dev/null
+++ b/70/9c59413dc640ba54ac0a8f616be35817008300
@@ -0,0 +1,108 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 585B4429E35\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:00:25 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5TnOY4DIpZuV for <notmuch@notmuchmail.org>;\r
+       Sat, 10 Jan 2015 01:00:22 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A0D99431E84\r
+       for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:00:22 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Y9ru7-0002My-To; Sat, 10 Jan 2015 05:00:19 -0400\r
+Received: (nullmailer pid 28192 invoked by uid 1000); Sat, 10 Jan 2015\r
+       09:00:14 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Todd <todd@electricoding.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Index Content-Type of attachments with a contenttype\r
+       prefix\r
+In-Reply-To: <1420849787-4401-1-git-send-email-todd@electricoding.com>\r
+References: <1420849787-4401-1-git-send-email-todd@electricoding.com>\r
+User-Agent: Notmuch/0.19+10~g215de26 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 10 Jan 2015 10:00:14 +0100\r
+Message-ID: <87ppanj9i9.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: Austin Clements <aclements@csail.mit.edu>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 10 Jan 2015 09:00:25 -0000\r
+\r
+Todd <todd@electricoding.com> writes:\r
+\r
+> I wanted to tag messages with calendar invitations, but couldn't as\r
+> the information wasn't indexed.\r
+>\r
+> This patch allows for queries for like:\r
+>\r
+> Find calendar invites\r
+> - contenttype:text/calendar or contenttype:applicaton/ics\r
+>\r
+> Find any image attachments\r
+> - contenttype:image\r
+>\r
+> Find all patches\r
+> - contenttype:text/x-patch\r
+\r
+The main issue,  that I won't really address in this message (because I'm\r
+hoping Austin finds time to comment) is upgrading the database. The short\r
+version is that a new "database feature" needs to be created.\r
+\r
+> --- a/NEWS\r
+> +++ b/NEWS\r
+> @@ -15,6 +15,12 @@ keyboard shortcuts to saved searches.\r
+>  Command-Line Interface\r
+>  ----------------------\r
+\r
+Minor point, 0.19 was released, you should start a new NEWS section for\r
+0.20 with date UNRELEASED\r
+\r
+> --- a/completion/notmuch-completion.bash\r
+> +++ b/completion/notmuch-completion.bash\r
+\r
+If you can without too much suffering, it would be nice to update the zsh completion at the same\r
+time.\r
+\r
+\r
+> +The **contenttype:** prefix can be used to search for specific\r
+> +content-types of attachments to email messages (as specified by the\r
+> +sender).\r
+> +\r
+\r
+I'm not 100% sure, but I did wonder if the docs should mention MIME\r
+somewhere, for people searching.\r
+>      { "attachment",         "XATTACHMENT" },\r
+> +    { "contenttype",                "XCONTENTTYPE"},\r
+>      { "subject",            "XSUBJECT"},\r
+\r
+I didn't work through all the details, but I did wonder if it was in\r
+some sense redundant to be indexing contenttype and also the existing\r
+attachement and encrypted pseudotags.  I guess this might be one of\r
+those cases where we are stuck with the extra indexing for now, until we\r
+sort out some query parsing issues.\r
+\r
+d\r
+\r