--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 201C3431FBD\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Feb 2014 10:17:59 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id UoK9remFvk4c for <notmuch@notmuchmail.org>;\r
+ Sun, 2 Feb 2014 10:17:51 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id D1723431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 2 Feb 2014 10:17:50 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WA1bn-0000Yx-Ab; Sun, 02 Feb 2014 18:17:45 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1WA1at-0004S4-VN; Sun, 02 Feb 2014 18:16:36 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime\r
+In-Reply-To: <cover.1385825425.git.jani@nikula.org>\r
+References: <cover.1385825425.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 02 Feb 2014 18:15:09 +0000\r
+Message-ID: <874n4hqt3m.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 6390360279f6ef9f4bb0e51df55b868d (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored 0.0 points. Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Feb 2014 18:17:59 -0000\r
+\r
+\r
+Patches 1-4 basically LGTM but patch 1 needs to be rebased since all the\r
+tests were renamed. I have a couple of minor comments on patches 2 and 3\r
+that I will send separately.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Sat, 30 Nov 2013, Jani Nikula <jani@nikula.org> wrote:\r
+> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish.\r
+>\r
+> Patches 1-4 do prep work to fix some of the differences in the parsers\r
+> in advance. Arguably they are not that bad regardless of the parser\r
+> change.\r
+>\r
+> Patches 5-6 actually make the change. Having two patches is a somewhat\r
+> artificial division, but perhaps makes it easier to review.\r
+>\r
+> Patch 7 is just a hack to make perf tests not ignore so many mails... we\r
+> have quite a bit of non-emails in the corpus by gmime parser\r
+> standards. And this illustrates one of the differences in the parsers.\r
+>\r
+>\r
+> BR,\r
+> Jani.\r
+>\r
+> Jani Nikula (7):\r
+> cli: sanitize tabs and newlines to spaces in notmuch search\r
+> cli: refactor reply from guessing\r
+> util: make sanitize string available in string util for reuse\r
+> cli: sanitize the received header before scanning for replies\r
+> lib: replace the header parser with gmime\r
+> lib: parse messages only once\r
+> HACK: fix broken messages in the perf test corpus\r
+>\r
+> lib/database.cc | 6 +-\r
+> lib/index.cc | 70 +-------\r
+> lib/message-file.c | 351 +++++++++++++-------------------------\r
+> lib/message.cc | 6 +\r
+> lib/notmuch-private.h | 20 ++-\r
+> notmuch-reply.c | 186 ++++++++++++--------\r
+> notmuch-search.c | 17 --\r
+> performance-test/perf-test-lib.sh | 4 +\r
+> test/search-output | 2 +-\r
+> util/string-util.c | 22 +++\r
+> util/string-util.h | 7 +\r
+> 11 files changed, 297 insertions(+), 394 deletions(-)\r
+>\r
+> -- \r
+> 1.8.4.2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff