Re: [PATCH 0/4] contrib: pick: allow more general format lines

diff --git a/7b/47cd06f4714bd09267ccad8c76cd6961cec211 b/7b/47cd06f4714bd09267ccad8c76cd6961cec211
new file mode 100644 (file)
index 0000000..696046b
--- /dev/null
+++ b/7b/47cd06f4714bd09267ccad8c76cd6961cec211
@@ -0,0 +1,127 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1784B431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 02:54:18 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2WFVm4CDnL7O for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Sep 2013 02:54:10 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 71E80431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Sep 2013 02:54:10 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 2426510007D;\r
+       Sat, 14 Sep 2013 12:54:01 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/4] contrib: pick: allow more general format lines\r
+In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 14 Sep 2013 12:54:00 +0300\r
+Message-ID: <m2ob7vg24n.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Sep 2013 09:54:18 -0000\r
+\r
+On Mon, Sep 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Currently pick makes the tree box graphics part of the "subject". This\r
+> is rather unsatisfactory: the tree graphics should be a field in their\r
+> own right.\r
+>\r
+> However, there is no mechanism in the current setup for allowing 2\r
+> fields to have fixed combined width but variable individual\r
+> width. Thus making the tree graphics a seperate field means that we\r
+> cannot keep the current display which is \r
+>\r
+> date (12 characters) authors (20 characters) tree+subject (54 characters) tags\r
+>\r
+> We solve this by extending the format specifier. Previously this was a\r
+> list of cons cells (field-name . format-string) We now allow the\r
+> left-side (the field-name) itself to be a list of cons cells in which case we\r
+> apply the formatting recursively.\r
+>\r
+> This means we can separate the tree box graphics into their own field\r
+> while maintaining the current format.\r
+>\r
+> Note that this will mean that people who have customised the\r
+> result-format will need to update their customisation.\r
+>\r
+> The patch is larger but relatively simple.\r
+>\r
+> Patch 1/4 is unrelated except I found it while doing this update: we\r
+> consistency we should print () for messages with no tags.\r
+>\r
+> Patch 2/4 is large but trivial: it moves the insertion up a level in\r
+> preparation for the recursive formatting.\r
+>\r
+> Patch 3/4 is also simple: it just allows the recursive formatting.\r
+>\r
+> Patch 4/4 separates out the tree field. This patch is large as\r
+> it allows separate tree faces (matching and non-matching). The\r
+> "genuine code" part of the patch is relatively small.\r
+>\r
+> Finally, this is the last series (apart from some extra tests and\r
+> keeping up with mainline progress) that I think pick needs before it's\r
+> ready for consideration in non-contrib mainline.\r
+\r
+This series LGTM. One thing that I saw could be "improved" a bit:\r
+in notmuch-pick-format-field drop the formatted-field parameter\r
+and setq's to it. Something that can be done in follow-up patch\r
+if there is nothing else to be changed. I don't want to have any\r
+more review effort on this patchset due to that change :D\r
+\r
++1\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r
+\r
+>\r
+>\r
+>\r
+> Mark Walters (4):\r
+>   contrib: pick: print () for a message with no tags\r
+>   contrib: pick: move the insertion of fields up a level\r
+>   contrib: pick: allow recursive message field formats\r
+>   contrib: pick: make the tree graphics a proper part of the format\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |   93 ++++++++++++++++++++++++---------\r
+>  1 files changed, 67 insertions(+), 26 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r