Re: [BUG/PATCH v2] emacs: Fix the References header in reply

diff --git a/1d/7f94596c4834b9892f10289a939ce0dc6a9c2a b/1d/7f94596c4834b9892f10289a939ce0dc6a9c2a
new file mode 100644 (file)
index 0000000..70bad12
--- /dev/null
+++ b/1d/7f94596c4834b9892f10289a939ce0dc6a9c2a
@@ -0,0 +1,99 @@
+Return-Path: <awg@xvx.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 34890431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Mar 2012 10:18:58 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id TUcRsC3tfUL6 for <notmuch@notmuchmail.org>;\r
+       Thu, 29 Mar 2012 10:18:57 -0700 (PDT)\r
+Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com\r
+       [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 6383F431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Mar 2012 10:18:57 -0700 (PDT)\r
+Received: by lahc1 with SMTP id c1so2816711lah.26\r
+       for <notmuch@notmuchmail.org>; Thu, 29 Mar 2012 10:18:54 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:sender:x-originating-ip:in-reply-to:references:date\r
+       :x-google-sender-auth:message-id:subject:from:to:cc:content-type\r
+       :content-transfer-encoding:x-gm-message-state;\r
+       bh=QxQGazzz2JFObUoHAKTZWvs+C/h7HkWunLLYwQq838A=;\r
+       b=guKi5mpSOV/7BlMTYqqQ2S3zYA06JIlWHnPtoXtB8c2X+aEW5+6T1fhlxUHFqGAjpt\r
+       zRHKaNotQzm7S9fLM/0vCu80HnkEkyUzWe3qSNbo5eLabctlFgi11DIFa8QGlm9l8K0F\r
+       c7eqzCJEAbYw+paqC+iJWwnzNjAJp3UYABJ/AE/Ni2gq+pTz/kXcLPNVL3WFdqn+asuA\r
+       zY4KKubLj0p4qfL7pJFPjwChOn6XseCrONB7YiMNd+Rfgw+VRJlblb7Itb4w8kVeQOFc\r
+       OOsbQppbrL7zxtDqVmWzsT1v247adcLM11n8MW7zHaUaTlDxTtMz2Lt7Cn6DcaDavVy5\r
+       H8EQ==\r
+MIME-Version: 1.0\r
+Received: by 10.152.108.171 with SMTP id hl11mr28107458lab.29.1333041534374;\r
+       Thu, 29 Mar 2012 10:18:54 -0700 (PDT)\r
+Sender: awg@xvx.ca\r
+Received: by 10.112.97.14 with HTTP; Thu, 29 Mar 2012 10:18:54 -0700 (PDT)\r
+X-Originating-IP: [128.221.197.57]\r
+In-Reply-To: <87aa2zjpmg.fsf@servo.finestructure.net>\r
+References: <1332991226-510-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <1332996818-15700-1-git-send-email-awg+notmuch@xvx.ca>\r
+       <87aa2zjpmg.fsf@servo.finestructure.net>\r
+Date: Thu, 29 Mar 2012 11:18:54 -0600\r
+X-Google-Sender-Auth: dOkJ0jlrET9fAC9RcnXzxNY94Vc\r
+Message-ID:\r
+ <CAMoJFUsqkmQDh6apmu+VMp40E7zb6n+Bonhi37d+sN1ORV5bOA@mail.gmail.com>\r
+Subject: Re: [BUG/PATCH v2] emacs: Fix the References header in reply\r
+From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Content-Type: text/plain; charset=ISO-8859-1\r
+Content-Transfer-Encoding: quoted-printable\r
+X-Gm-Message-State:\r
+ ALoCoQn7pVwxYy0lgGaYexoYyWIp8ZjTeFgbCl1+RCHgVfi/4FUllJpOhpD32ahwI5aMQ2Y1DGKp\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Mar 2012 17:18:58 -0000\r
+\r
+Hi Jamie,\r
+\r
+On Thu, Mar 29, 2012 at 11:14, Jameson Graef Rollins\r
+<jrollins@finestructure.net> wrote:\r
+> I just tested this patch and it does seem to fix the issue. =A0However, a\r
+> side effect seems to be that the References header is now appearing as\r
+> the first header in the reply buffer, rather than the last, as it used\r
+> to. =A0I suppose this is merely aesthetic, but I did prefer the ordering\r
+> as it was before. =A0Is there a way to tweak the\r
+> message-header-format-alist so that the References header appears last\r
+> again?\r
+\r
+That's actually fixed by the new version [1]. As Austin mentioned in\r
+his review, the order of message-header-format-alist determines the\r
+order of the headers.\r
+\r
+[1] id:"1333038410-17927-3-git-send-email-awg+notmuch@xvx.ca"\r
+\r
+> Given the various things that are being affected by this, it would\r
+> probably be good to add a test for this as well.\r
+\r
+Yeah, I think a test would be good. This isn't caught by the existing\r
+emacs reply tests because the References and User-Agent headers are\r
+hidden by default. Is there a function in emacs to tell message-mode\r
+to show all the headers, so we can verify that they're correct?\r
+\r
+--=20\r
+Adam\r