Re: [PATCH] emacs: add support for stashing the thread id in show view

diff --git a/42/70c83ab3e07433a9d05e8e26125f5500d4ef7a b/42/70c83ab3e07433a9d05e8e26125f5500d4ef7a
new file mode 100644 (file)
index 0000000..fd88c07
--- /dev/null
+++ b/42/70c83ab3e07433a9d05e8e26125f5500d4ef7a
@@ -0,0 +1,122 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6341F431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  6 Dec 2012 14:35:39 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nDkv4cGqqt0T for <notmuch@notmuchmail.org>;\r
+       Thu,  6 Dec 2012 14:35:36 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E768A431FAE\r
+       for <notmuch@notmuchmail.org>; Thu,  6 Dec 2012 14:35:35 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Tgk2Y-0003A2-1L; Thu, 06 Dec 2012 22:35:34 +0000\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Tgk2X-0007bZ-NV; Thu, 06 Dec 2012 22:35:33 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: add support for stashing the thread id in show\r
+ view\r
+In-Reply-To: <1354827443-10549-1-git-send-email-jani@nikula.org>\r
+References: <1354827443-10549-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.14+81~g9730584 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 06 Dec 2012 22:35:37 +0000\r
+Message-ID: <87mwxqhkqu.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 2d8b9fbec95b84747639e893bbb93984 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.7\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored -1.7 points.\r
+       Summary of the scoring: \r
+       * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+       *      medium trust\r
+       *      [138.37.6.40 listed in list.dnswl.org]\r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.6 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 06 Dec 2012 22:35:39 -0000\r
+\r
+\r
+On Thu, 06 Dec 2012, Jani Nikula <jani@nikula.org> wrote:\r
+> Add a prefix argument to notmuch-show-stash-message-id to stash thread\r
+> id instead of message id.\r
+> ---\r
+>  emacs/notmuch-show.el |   13 +++++++++----\r
+>  1 file changed, 9 insertions(+), 4 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 4d6c014..2245b4f 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1901,10 +1901,15 @@ thread from search."\r
+>    (interactive)\r
+>    (notmuch-common-do-stash (notmuch-show-get-from)))\r
+>  \r
+> -(defun notmuch-show-stash-message-id ()\r
+> -  "Copy id: query matching the current message to kill-ring."\r
+> -  (interactive)\r
+> -  (notmuch-common-do-stash (notmuch-show-get-message-id)))\r
+> +(defun notmuch-show-stash-message-id (&optional thread-id)\r
+> +  "Copy id: query matching the current message to kill-ring.\r
+> +\r
+> +If invoked with a prefix argument (or THREAD-ID is non-nil), copy\r
+> +thread: query matching the current thread to kill-ring."\r
+> +  (interactive "P")\r
+> +  (if thread-id\r
+> +      (notmuch-common-do-stash notmuch-show-thread-id)\r
+> +    (notmuch-common-do-stash (notmuch-show-get-message-id))))\r
+>  \r
+\r
+Basically this looks good to me. My one criticism is the name of the\r
+argument: thread-id looks like it should be umm, a thread-id. Maybe\r
+thread-id-wanted or something?\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+>  (defun notmuch-show-stash-message-id-stripped ()\r
+>    "Copy message ID of current message (sans `id:' prefix) to kill-ring."\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r