Re: [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory...

diff --git a/34/f1d3d55f0d0045c769fafa8b6e0e39e8379d08 b/34/f1d3d55f0d0045c769fafa8b6e0e39e8379d08
new file mode 100644 (file)
index 0000000..03cb0c2
--- /dev/null
+++ b/34/f1d3d55f0d0045c769fafa8b6e0e39e8379d08
@@ -0,0 +1,71 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1DE03431FCB\r
+       for <notmuch@notmuchmail.org>; Wed, 23 May 2012 18:53:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id o+thp8fpcuCQ for <notmuch@notmuchmail.org>;\r
+       Wed, 23 May 2012 18:53:31 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id C5CE7431FC4\r
+       for <notmuch@notmuchmail.org>; Wed, 23 May 2012 18:53:31 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.89.108] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32)\r
+       (Exim 4.72) (envelope-from <bremner@unb.ca>)\r
+       id 1SXNF4-0006hj-KQ; Wed, 23 May 2012 22:53:30 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.77)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1SXNEz-0005CZ-BH; Wed, 23 May 2012 22:53:25 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/9] lib: Make directory document creation optional for\r
+       _notmuch_directory_create\r
+In-Reply-To: <1337314423-3702-2-git-send-email-amdragon@mit.edu>\r
+References: <1337314423-3702-1-git-send-email-amdragon@mit.edu>\r
+       <1337314423-3702-2-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.13 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 23 May 2012 22:53:25 -0300\r
+Message-ID: <87396q1h0q.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 24 May 2012 01:53:32 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> Previously this function would create directory documents if they\r
+> didn't exist.  As a result, it could only be used on writable\r
+> databases.  This adds an argument to make creation optional and to\r
+> make this function work on read-only databases.  We use a flag\r
+> argument to avoid a bare boolean and to permit future expansion.\r
+\r
+Series pushed, \r
+\r
+d\r
+\r
+PS. I marked a couple other of your patches stale in nmbug.\r
+\r