Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix= and properly creat...

diff --git a/50/b1a6b395a66c9b75ffed0599aa2c3864b37896 b/50/b1a6b395a66c9b75ffed0599aa2c3864b37896
new file mode 100644 (file)
index 0000000..a2dc95a
--- /dev/null
+++ b/50/b1a6b395a66c9b75ffed0599aa2c3864b37896
@@ -0,0 +1,99 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B2F79431FBD;\r
+       Fri,  4 Dec 2009 16:56:58 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id MtsIeXa8NAfm; Fri,  4 Dec 2009 16:56:57 -0800 (PST)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A938B431FAE;\r
+       Fri,  4 Dec 2009 16:56:57 -0800 (PST)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id 620622542FB; Fri,  4 Dec 2009 16:56:57 -0800 (PST)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+In-Reply-To: <20091205002050.GA26479@finestructure.net>\r
+References: <1259452657-27608-1-git-send-email-jrollins@finestructure.net>\r
+       <87ocmee0sg.fsf@yoom.home.cworth.org>\r
+       <20091205002050.GA26479@finestructure.net>\r
+Date: Fri, 04 Dec 2009 16:56:56 -0800\r
+Message-ID: <878wdidyqv.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: [notmuch] [PATCH 1/3] fix configure script to handle --prefix=\r
+ and properly create Makefile.config\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 05 Dec 2009 00:56:58 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Fri, 4 Dec 2009 19:20:50 -0500, Jameson Graef Rollins <jrollins@finestru=\r
+cture.net> wrote:\r
+> > Your commit message has that flag word of "also" in it, and as it turns\r
+> > out, the removal of Makefile.config from the repository has actually\r
+> > happened already. But that was easy enough to fix.\r
+>=20\r
+> I was thinking that the removal of the Makefile.config from the repo\r
+> went together with the new auto-generation of that file from configure\r
+> script.  Do you think they still should have been separate patches?\r
+\r
+No, it was fine. It's just funny to me how often that word "also" in a\r
+commit message seems to end up being a predictor for things later, (like\r
+this case where half of a patch is already implemented, or much worse,\r
+how often a bisect lands on a commit that makes multiple changes).\r
+\r
+So I was really just expressing amusement at seeing it again.\r
+\r
+> > > +# option parsing\r
+> > > +for option; do\r
+> > > +    if [ "${option%=3D*}" =3D '--prefix' ] ; then\r
+> > > +        PREFIX=3D"${option#*=3D}"\r
+> > > +    fi\r
+> > > +done\r
+> >=20\r
+> > I've gone ahead and committed that now. Then I noticed that we should\r
+> > really use ${option%%=3D*} to support the case of an option value\r
+> > containing an '=3D' character. So I fixed that.\r
+>=20\r
+> Ah, good catch.  Sorry about that.=20=20\r
+\r
+No worries. I was just impressed at the tiny amount of code needed for\r
+the parsing here, so ended up looking closer to understand it.\r
+\r
+> Autoconf terrifies me, so I agree I'm quite happy with the simple\r
+> configure script we have right now.  If it gets the job done without\r
+> having to deal with autoconf then that's great in my book.\r
+\r
+Cool. At least not everyone thinks I'm crazy then. That's\r
+encouraging. :-)\r
+\r
+=2DCarl\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iD8DBQFLGa/Z6JDdNq8qSWgRAjTaAKCCQ0n3l9Ae6Y7mWwaoJezCbBDPagCfSEwT\r
+MXBUsNBliQ3aQFzRjHlL0V8=\r
+=+Rd8\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r