Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag"

diff --git a/18/ec857f078e9d3604db869e53f88425f9ad5283 b/18/ec857f078e9d3604db869e53f88425f9ad5283
new file mode 100644 (file)
index 0000000..69985fc
--- /dev/null
+++ b/18/ec857f078e9d3604db869e53f88425f9ad5283
@@ -0,0 +1,130 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0E5EB431FBC\r
+       for <notmuch@notmuchmail.org>; Mon,  2 Apr 2012 14:31:55 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.699\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
+       tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id d5gajtMirzia for <notmuch@notmuchmail.org>;\r
+       Mon,  2 Apr 2012 14:31:54 -0700 (PDT)\r
+Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com\r
+       [209.85.160.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 623B2431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  2 Apr 2012 14:31:54 -0700 (PDT)\r
+Received: by pbcuo1 with SMTP id uo1so5547299pbc.26\r
+       for <notmuch@notmuchmail.org>; Mon, 02 Apr 2012 14:31:53 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=mime-version:in-reply-to:references:date:message-id:subject:from:to\r
+       :cc:content-type:x-gm-message-state;\r
+       bh=R7PNME8/t46AkquKSLyj9c69/ym3RE00lN3h8RoGDXQ=;\r
+       b=ZgPfIyZM3Yq9L/ltyH+zZv4dmYMM6vWBPiQcCVTyUtDXgWMgV4QNfR2pKSTiJbtNtf\r
+       4MPvCkyiecb/hSZVdr9C5hZFDMfxVX4YTiODT/Z2RVeDI5lwS+mCQbd00w6+fVxwCkIX\r
+       eRpTN2PAy3IwuTZ28lafbNdbzazdpQWIlDjt5hahcObETZeg9YATsTn278h+mQi+uvI/\r
+       4P2vCy8npoJJ84TDsYeR+AFDEDuXptNLWr0sClSHB0GAy9/VPVCw/W3f+CN7tzlwKwf+\r
+       JEFuTmZGUFp5m+vTQhmuisnjmdwm0XCaSJcLCN1k1RDgBgUL2JJt0QEVbHw8sllq83uY\r
+       J9gg==\r
+MIME-Version: 1.0\r
+Received: by 10.68.239.233 with SMTP id vv9mr23869933pbc.75.1333402313538;\r
+       Mon, 02 Apr 2012 14:31:53 -0700 (PDT)\r
+Received: by 10.68.231.104 with HTTP; Mon, 2 Apr 2012 14:31:53 -0700 (PDT)\r
+Received: by 10.68.231.104 with HTTP; Mon, 2 Apr 2012 14:31:53 -0700 (PDT)\r
+In-Reply-To: <87fwcl4yr8.fsf@servo.finestructure.net>\r
+References: <cover.1333231401.git.jani@nikula.org>\r
+       <f360a40bed50208d146aee8b06946b1b8315e818.1333231401.git.jani@nikula.org>\r
+       <87ty123tpc.fsf@servo.finestructure.net>\r
+       <87aa2tc22z.fsf@zancas.localnet>\r
+       <87iphh50hz.fsf@servo.finestructure.net>\r
+       <CAB+hUn_J9oOmbWaQ+_2yGG6i6ecDXbfJWYbpaYx_kbSnAH+EcA@mail.gmail.com>\r
+       <87fwcl4yr8.fsf@servo.finestructure.net>\r
+Date: Tue, 3 Apr 2012 00:31:53 +0300\r
+Message-ID:\r
+ <CAB+hUn-5yB15na2kFMZOjOEujKQTWHiefvgQYsT4Zi3UOzKwQw@mail.gmail.com>\r
+Subject: Re: [PATCH 6/8] cli: add support for batch tagging operations to\r
+       "notmuch tag"\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Jameson Graef Rollins <jrollins@finestructure.net>\r
+Content-Type: multipart/alternative; boundary=047d7b33d1903dbdb204bcb8eb79\r
+X-Gm-Message-State:\r
+ ALoCoQn/zOZchnITk4s6DzhfeLot/Wr6sE46B9OCmZmrR7LMT8x47gJOpoY9HKy2kZD1id6B4Zln\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 02 Apr 2012 21:31:55 -0000\r
+\r
+--047d7b33d1903dbdb204bcb8eb79\r
+Content-Type: text/plain; charset=UTF-8\r
+\r
+On Apr 3, 2012 12:20 AM, "Jameson Graef Rollins" <jrollins@finestructure.net>\r
+wrote:\r
+>\r
+> On Mon, Apr 02 2012, Jani Nikula <jani@nikula.org> wrote:\r
+> > Batch tagging brings performance and atomicity by opening and closing\r
+the\r
+> > db only once. The hex encoding handles insane message ids and tags.\r
+> > Otherwise there should be no difference.\r
+>\r
+> I can maybe see performance in terms of opening and closing the db only\r
+> once, but atomicity?  Not sure I see how that is improved.\r
+\r
+Err, I meant locking, sorry. Nobody else is able to alter the db while\r
+batch tagging is in progress.\r
+\r
+>\r
+> And shouldn't we be able to improve the handling of command line\r
+> arguments so that we get the same encoding handling on the command line\r
+> as we would from stdin?\r
+>\r
+> jamie.\r
+\r
+--047d7b33d1903dbdb204bcb8eb79\r
+Content-Type: text/html; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+<p><br>\r
+On Apr 3, 2012 12:20 AM, &quot;Jameson Graef Rollins&quot; &lt;<a href=3D"m=\r
+ailto:jrollins@finestructure.net">jrollins@finestructure.net</a>&gt; wrote:=\r
+<br>\r
+&gt;<br>\r
+&gt; On Mon, Apr 02 2012, Jani Nikula &lt;<a href=3D"mailto:jani@nikula.org=\r
+">jani@nikula.org</a>&gt; wrote:<br>\r
+&gt; &gt; Batch tagging brings performance and atomicity by opening and clo=\r
+sing the<br>\r
+&gt; &gt; db only once. The hex encoding handles insane message ids and tag=\r
+s.<br>\r
+&gt; &gt; Otherwise there should be no difference.<br>\r
+&gt;<br>\r
+&gt; I can maybe see performance in terms of opening and closing the db onl=\r
+y<br>\r
+&gt; once, but atomicity? =C2=A0Not sure I see how that is improved.</p>\r
+<p>Err, I meant locking, sorry. Nobody else is able to alter the db while b=\r
+atch tagging is in progress.</p>\r
+<p>&gt;<br>\r
+&gt; And shouldn&#39;t we be able to improve the handling of command line<b=\r
+r>\r
+&gt; arguments so that we get the same encoding handling on the command lin=\r
+e<br>\r
+&gt; as we would from stdin?<br>\r
+&gt;<br>\r
+&gt; jamie.<br>\r
+</p>\r
+\r
+--047d7b33d1903dbdb204bcb8eb79--\r