Re: [PATCH 4/4] test: give unique timestamps to messages

diff --git a/85/4f1ea8342c8abcbdcba009df4981e3ae5f157f b/85/4f1ea8342c8abcbdcba009df4981e3ae5f157f
new file mode 100644 (file)
index 0000000..f7d8d9b
--- /dev/null
+++ b/85/4f1ea8342c8abcbdcba009df4981e3ae5f157f
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 3FA12431FCF\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Dec 2013 00:21:09 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5D+EmkDFunDc for <notmuch@notmuchmail.org>;\r
+       Mon,  9 Dec 2013 00:21:01 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7A941431FC0\r
+       for <notmuch@notmuchmail.org>; Mon,  9 Dec 2013 00:21:01 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 0ECBD10005D;\r
+       Mon,  9 Dec 2013 10:20:52 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 4/4] test: give unique timestamps to messages\r
+In-Reply-To: <87lhzult3h.fsf@maritornes.cs.unb.ca>\r
+References: <1386517946-22054-1-git-send-email-david@tethera.net>\r
+       <1386517946-22054-5-git-send-email-david@tethera.net>\r
+       <m28uvvnowo.fsf@guru.guru-group.fi>\r
+       <87lhzult3h.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.17~rc1+17~ga2e1a2f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 09 Dec 2013 10:20:51 +0200\r
+Message-ID: <m28uvusae4.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 09 Dec 2013 08:21:09 -0000\r
+\r
+On Mon, Dec 09 2013, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>>>      if [ -z "${template[date]}" ]; then\r
+>>> -  template[date]="Fri, 05 Jan 2001 15:43:57 +0000"\r
+>>> +  template[date]=$(date -Ru -d@$((978709437 - gen_msg_cnt)))\r
+>>\r
+>> I am afraid this is not portable (although not sure). This could work:\r
+>>\r
+>> _s=$((3599 - gen_msg_cnt))\r
+>> template[date]="Fri, 05 Jan 2001 15:$((_s / 60)):$((_s % 60)) +0000"\r
+>>\r
+>\r
+> How about this instead?\r
+>\r
+> diff --git a/test/test-lib.sh b/test/test-lib.sh\r
+> index 792e477..22a4d7f 100644\r
+> --- a/test/test-lib.sh\r
+> +++ b/test/test-lib.sh\r
+> @@ -356,7 +356,8 @@ generate_message ()\r
+>      fi\r
+>  \r
+>      if [ -z "${template[date]}" ]; then\r
+> -    template[date]=$(date -Ru -d@$((978709437 - gen_msg_cnt)))\r
+> +    template[date]=$(TZ=UTC printf "%(%a, %d %b %Y %T %z)T\n" \\r
+> +                    $((978709437 - gen_msg_cnt)))\r
+>      fi\r
+\r
+$ printf "%(%a, %d %b %Y %T %z)T\n" 978709437\r
+printf: %(: invalid directive\r
+zsh: exit 1\r
+\r
+$ bash -c 'printf "%(%a, %d %b %Y %T %z)T\n" 978709437'\r
+Fri, 05 Jan 2001 17:43:57 +0200\r
+\r
+\r
+Using bash builtin is fine by me! :D\r
+\r
+BTW: this works too:\r
+\r
+bash -c 'TZ=UTC printf -v foo[bar] "%(%a, %d %b %Y %T %z)T\n" 978709437; echo ${foo[bar]}'\r
+\r
+\r
+Tomi\r