RE: [PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads

diff --git a/a4/1979f5ca1eeda795a90916bf91fdb8272d7509 b/a4/1979f5ca1eeda795a90916bf91fdb8272d7509
new file mode 100644 (file)
index 0000000..8fa0d98
--- /dev/null
+++ b/a4/1979f5ca1eeda795a90916bf91fdb8272d7509
@@ -0,0 +1,87 @@
+Return-Path: <felipe.contreras@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 21F56431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Apr 2013 12:41:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ubg2vWlFWz-r for <notmuch@notmuchmail.org>;\r
+       Tue,  2 Apr 2013 12:41:29 -0700 (PDT)\r
+Received: from mail-ye0-f182.google.com (mail-ye0-f182.google.com\r
+       [209.85.213.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9560E431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Apr 2013 12:41:29 -0700 (PDT)\r
+Received: by mail-ye0-f182.google.com with SMTP id r5so122602yen.27\r
+       for <notmuch@notmuchmail.org>; Tue, 02 Apr 2013 12:41:29 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=x-received:date:from:to:cc:message-id:in-reply-to:references\r
+       :subject:mime-version:content-type:content-transfer-encoding;\r
+       bh=ZS6d6SBYzVOtiiNffwaFq8cSRrwBjcDa/DP4drivaQQ=;\r
+       b=0/ExunKd1Znnzz4no2Manjm3ldUOWgN/pVj/L+7ZTmfjjYLMvs7hMO9hAAY9f3FlfV\r
+       aEHO4HBNNMK49REbV1giq2x2DGIcnyupUt1Gqc/0ZNs+bV9i3NkNKp2iDONKhlUPsrJ8\r
+       15e/3m7s2fJfThb2Zha+MQrnuZ9gb4okc/fG/79h132dkxd4IMhtsuRTScFWaC7ywXIX\r
+       qAocXIkYSaLE3ROGSEzh9HHy2PHw9JBPHmvbUalRlLV2jFrrV1kx0jCLRiE5wbDChWCA\r
+       NqH53ivg5miZ1toDh/9Z8ARb1Q89X53vNNrDuatbyKVqEZfAcyXDeEv8G3HbtzGnUo5v\r
+       oefA==\r
+X-Received: by 10.236.86.105 with SMTP id v69mr15936005yhe.17.1364931689125;\r
+       Tue, 02 Apr 2013 12:41:29 -0700 (PDT)\r
+Received: from localhost (187-163-100-70.static.axtel.net. [187.163.100.70])\r
+       by mx.google.com with ESMTPS id t27sm5003338yhm.20.2013.04.02.12.41.26\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Tue, 02 Apr 2013 12:41:28 -0700 (PDT)\r
+Date: Tue, 02 Apr 2013 13:39:45 -0600\r
+From: Felipe Contreras <felipe.contreras@gmail.com>\r
+To: "Kirill A. Shutemov" <kirill@shutemov.name>, \r
+       Felipe Contreras <felipe.contreras@gmail.com>\r
+Message-ID: <515b34012ebf8_146e1045e10937e4@nysa.mail>\r
+In-Reply-To: <1359388340-27136-5-git-send-email-kirill@shutemov.name>\r
+References: <1359388340-27136-1-git-send-email-kirill@shutemov.name>\r
+       <1359388340-27136-5-git-send-email-kirill@shutemov.name>\r
+Subject: RE: [PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads\r
+Mime-Version: 1.0\r
+Content-Type: text/plain;\r
+ charset=utf-8\r
+Content-Transfer-Encoding: 7bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 02 Apr 2013 19:41:30 -0000\r
+\r
+Kirill A. Shutemov wrote:\r
+> From: "Kirill A. Shutemov" <kirill@shutemov.name>\r
+> \r
+> If the option set, folders list shows count of threads, not messages\r
+\r
+>                              folders.each do |name, search|\r
+>                                      q = db.query(search)\r
+>                                      $searches << search\r
+> -                                    b << "%9d %-20s (%s)" % [q.search_messages.count, name, search]\r
+> +                                    count = count_threads == 0 ?\r
+> +                                            q.search_messages.count : q.search_threads.count\r
+\r
+I prefer:\r
+count = count_threads ? q.search_threads.count : q.search_messages.count\r
+\r
+But other than that looks good to me. Applied.\r
+\r
+-- \r
+Felipe Contreras\r