Re: [PATCH 1/3] Add notmuch_database_close_compact

diff --git a/c8/35e7bec7db32aa2cd56d51113138c078a3a08c b/c8/35e7bec7db32aa2cd56d51113138c078a3a08c
new file mode 100644 (file)
index 0000000..8e6c07e
--- /dev/null
+++ b/c8/35e7bec7db32aa2cd56d51113138c078a3a08c
@@ -0,0 +1,107 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 15BC7431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Aug 2012 23:26:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id GyHEtslHUU18 for <notmuch@notmuchmail.org>;\r
+       Wed, 22 Aug 2012 23:25:59 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 18DF1431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Aug 2012 23:25:59 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 82465100386; Thu, 23 Aug 2012 09:26:06 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr>\r
+Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact\r
+In-Reply-To: <87haruxiae.fsf@kaki.tech.prive.nic.fr>\r
+References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>\r
+       <1345476704-17091-2-git-send-email-bgamari.foss@gmail.com>\r
+       <m27gssitot.fsf@guru.guru-group.fi> <87y5l8z4dw.fsf@gmail.com>\r
+       <m2txvv794d.fsf@guru.guru-group.fi>\r
+       <87haruxiae.fsf@kaki.tech.prive.nic.fr>\r
+User-Agent: Notmuch/0.14+8~gd6b499d (http://notmuchmail.org) Emacs/23.1.1\r
+       (x86_64-redhat-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 23 Aug 2012 09:26:06 +0300\r
+Message-ID: <m2harucef5.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 23 Aug 2012 06:26:00 -0000\r
+\r
+On Thu, Aug 23 2012, Kim Minh Kaplan <kimminh.kaplan+nomuch@afnic.fr> wrote:\r
+\r
+> Tomi Ollila=C2=A0:\r
+>\r
+>> On Tue, Aug 21 2012, Ben Gamari wrote:\r
+>>\r
+>>> Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the\r
+>>> public API.\r
+>>\r
+>> Presuming that those variables are always numeric the comparison could b=\r
+e:\r
+>>\r
+>> if [ ${xapian_major_version} -gt 1 ] ||=20\r
+>>    [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -gt 2 ] ||=\r
+=20\r
+>>    [ ${xapian_major_version} -eq 1 -a ${xapian_minor_version} -eq 2 -a \\r
+>>      ${xapian_subminor_version} -ge 6 ]; then\r
+>>\r
+>> (I could not figure out anything shorter and/or cleaner)\r
+>\r
+> Try:\r
+>\r
+>     case "${xapian_version}" in\r
+>          0.*|1.[01].*|1.2.[0-5]) ;;\r
+>          *) ... ;;\r
+>     esac\r
+\r
+That sure is shorter -- and splitting xapian_version\r
+is not required...\r
+\r
+.. also that would take care the (improbable?) case that\r
+`${xapian_config} -- version` outputs something else than\r
+#.#.# in the future.\r
+\r
+On the other hand, the above doesn't catch junk, so maybe:\r
+\r
+     case ${xapian_version} in\r
+          0.*|1.[01].*|1.2.[0-5]) handle no case ;;=20=20\r
+          [1-9]*.[0-9]*.[0-9]*) handle yes case -- approximated test ;;\r
+          *) failure ;;\r
+     esac\r
+\r
+(and we (approximately) expect #.#.#)\r
+\r
+In any case, excellent idea !\r
+\r
+\r
+> Kim Minh.\r
+\r
+Thanks,\r
+\r
+Tomi\r