Re: [PATCH 1/6] lib: Clean up error handling in _notmuch_thread_create

diff --git a/c3/f58c169109aa317ca6116a2ce3ebbcad6e032d b/c3/f58c169109aa317ca6116a2ce3ebbcad6e032d
new file mode 100644 (file)
index 0000000..ab0009d
--- /dev/null
+++ b/c3/f58c169109aa317ca6116a2ce3ebbcad6e032d
@@ -0,0 +1,75 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 80EDC431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 18 Feb 2013 17:16:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id zutLMeFW5JgR for <notmuch@notmuchmail.org>;\r
+       Mon, 18 Feb 2013 17:16:51 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F3FA4431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 18 Feb 2013 17:16:50 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1U7bpA-0005pf-RY; Mon, 18 Feb 2013 21:16:49 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1U7bp4-0003iQ-LG; Mon, 18 Feb 2013 21:16:42 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 1/6] lib: Clean up error handling in\r
+ _notmuch_thread_create\r
+In-Reply-To: <87fw0tumuy.fsf@zancas.localnet>\r
+References: <1353819427-13182-1-git-send-email-amdragon@mit.edu>\r
+       <1353819427-13182-2-git-send-email-amdragon@mit.edu>\r
+       <87fw0tumuy.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.15.2+32~g16aa65b (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 18 Feb 2013 21:16:42 -0400\r
+Message-ID: <87bobhumpx.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 19 Feb 2013 01:16:51 -0000\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+>\r
+>> Previously, there were various opportunities for memory leaks in the\r
+>> error-handling paths of this function.  Use a local talloc context and\r
+>> some reparenting to make eliminate these leaks, while keeping the\r
+>> control flow simple.\r
+>\r
+> pushed all but the python bindings patch.\r
+\r
+any comments on that patch, Justus?\r
+\r
+For reference, id:1353819427-13182-6-git-send-email-amdragon@mit.edu\r
+\r
+d\r