Re: [PATCH v2] lib: Start all function names in notmuch-private.h with

diff --git a/2a/f42d3a433b61aae00c1e8b9cf58063a7ff430b b/2a/f42d3a433b61aae00c1e8b9cf58063a7ff430b
new file mode 100644 (file)
index 0000000..f340d7e
--- /dev/null
+++ b/2a/f42d3a433b61aae00c1e8b9cf58063a7ff430b
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1FC1B431FBD\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 08:44:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id umSiob94r6y6 for <notmuch@notmuchmail.org>;\r
+       Sun, 13 Jul 2014 08:43:59 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A5C74431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 13 Jul 2014 08:43:59 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X6LwU-0007a1-Vc; Sun, 13 Jul 2014 12:43:58 -0300\r
+Received: (nullmailer pid 24895 invoked by uid 1000); Sun, 13 Jul 2014\r
+       15:43:55 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] lib: Start all function names in notmuch-private.h\r
+ with\r
+In-Reply-To: <1399974245-77744-1-git-send-email-cceleri@cs.stanford.edu>\r
+References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399974245-77744-1-git-send-email-cceleri@cs.stanford.edu>\r
+User-Agent: Notmuch/0.18.1+29~gb5327d4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 13 Jul 2014 12:43:55 -0300\r
+Message-ID: <87wqbhe01w.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 13 Jul 2014 15:44:07 -0000\r
+\r
+Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+\r
+> As noted in devel/STYLE, every private library function should start\r
+> with _notmuch. This patch corrects function naming that did not adhere\r
+> to this style in lib/notmuch-private.h. In particular, the old function\r
+> names that now begin with _notmuch are\r
+>\r
+>     notmuch_sha1_of_file\r
+>     notmuch_sha1_of_string\r
+>     notmuch_message_file_close\r
+>     notmuch_message_file_get_header\r
+>     notmuch_message_file_open\r
+>     notmuch_message_get_author\r
+>     notmuch_message_set_author\r
+>\r
+\r
+finally pushed,\r
+\r
+d\r