Re: [PATCH] WIP: regexp matching in 'subject' and 'from'

diff --git a/78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82 b/78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82
new file mode 100644 (file)
index 0000000..9000d35
--- /dev/null
+++ b/78/c8afd550c7a212d2fcddc63dfc4e1ab5a0cf82
@@ -0,0 +1,73 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 6C45F6DE0222\r
+ for <notmuch@notmuchmail.org>; Fri, 10 Jun 2016 04:12:06 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.571\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.571 tagged_above=-999 required=5 tests=[AWL=-0.081,\r
+  SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id SES7IQoqj5i8 for <notmuch@notmuchmail.org>;\r
+ Fri, 10 Jun 2016 04:11:58 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 19FA96DE0130\r
+ for <notmuch@notmuchmail.org>; Fri, 10 Jun 2016 04:11:58 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 6DD82100104;\r
+ Fri, 10 Jun 2016 14:11:43 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH] WIP: regexp matching in 'subject' and 'from'\r
+In-Reply-To: <87d1npydc2.fsf@zancas.localnet>\r
+References: <1465265149-7174-1-git-send-email-david@tethera.net>\r
+ <1465525688-30913-1-git-send-email-david@tethera.net>\r
+ <87d1npydc2.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.22+32~gd4854c5 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Fri, 10 Jun 2016 14:11:43 +0300\r
+Message-ID: <m2r3c5ti1c.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 10 Jun 2016 11:12:06 -0000\r
+\r
+On Fri, Jun 10 2016, David Bremner <david@tethera.net> wrote:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> +#ifdef HAVE_XAPIAN_FIELD_PROCESSOR\r
+>> +    delete notmuch->from_re_field_processor;\r
+>> +    notmuch->from_re_field_processor = NULL;\r
+>> +    delete notmuch->subject_re_field_processor;\r
+>> +    notmuch->subject_re_field_processor = NULL;\r
+>> +#endif\r
+>\r
+> and of course everywhere it says #ifdef HAVE_XAPIAN_FIELD_PROCESSOR, is\r
+> should say #if.\r
+\r
+... is there a static code analyzer which notices such a mistakes... ?\r
+\r
+i did marked that version trivial, which completes the thought that there\r
+are no such thing as trivial changes ;/\r
+\r
+\r
+> d\r