Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when...

diff --git a/1f/3a54bda54e68be6642cc72484aa49f9ed641fc b/1f/3a54bda54e68be6642cc72484aa49f9ed641fc
new file mode 100644 (file)
index 0000000..dd1a9ac
--- /dev/null
+++ b/1f/3a54bda54e68be6642cc72484aa49f9ed641fc
@@ -0,0 +1,101 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 438A9421192\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 06:22:49 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b24d-r4bZgb7 for <notmuch@notmuchmail.org>;\r
+       Wed,  1 Feb 2012 06:22:48 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 74B42429E5B\r
+       for <notmuch@notmuchmail.org>; Wed,  1 Feb 2012 06:22:48 -0800 (PST)\r
+Received: by bke11 with SMTP id 11so1210308bke.26\r
+       for <notmuch@notmuchmail.org>; Wed, 01 Feb 2012 06:22:47 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=p+ua8PV7E+yJZnmN6UGFJ6pObshfJln/6WSNpKCVxO0=;\r
+       b=vzcmcxzl9hiEIoy7pe6hRtT/Wp87KghnQeq82jc3Sp4PalATgklRkIzQ7qeGUfC29K\r
+       tloqotLRxelbBs3F6ZJgW0YmPXf73M8l1GOPheWSBzNGBvkQitAzdCCnRpWxJ92ENgwf\r
+       f+GECcNdK4FIM2bleIpcNTDqsdhvtcqHa6IvU=\r
+Received: by 10.205.124.15 with SMTP id gm15mr13158948bkc.63.1328106166962;\r
+       Wed, 01 Feb 2012 06:22:46 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id o26sm48807015bko.14.2012.02.01.06.22.45\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 01 Feb 2012 06:22:46 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Pieter Praet <pieter@praet.org>, David Edmondson <dme@dme.org>,\r
+       David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn\r
+       ..." with "(when ..."\r
+In-Reply-To: <874nva7jkk.fsf@praet.org>\r
+References: <87k44uprvy.fsf@praet.org>\r
+       <1326532638-22068-1-git-send-email-pieter@praet.org>\r
+       <87y5ssxam7.fsf@zancas.localnet>\r
+       <CAB+hUn-GmONr24nfxBkt59TzHHyZiD1wioYXoPh9wy-rZR-m2g@mail.gmail.com>\r
+       <87ty3fycje.fsf@zancas.localnet>\r
+       <cunliopilwj.fsf@hotblack-desiato.hh.sledj.net>\r
+       <874nva7jkk.fsf@praet.org>\r
+User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 01 Feb 2012 18:21:33 +0400\r
+Message-ID: <87bopimy6q.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 01 Feb 2012 14:22:49 -0000\r
+\r
+On Wed, 01 Feb 2012 14:46:19 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> On Mon, 30 Jan 2012 09:23:40 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote:\r
+> > > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:\r
+> > > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:\r
+> > > > \r
+> > > > Sometimes someone (Dmitry?) sent patches that separated a small functional\r
+> > > > change, and the big non-functional indentation change it caused,\r
+> > > > separately. Would you prefer (or tolerate ;) that style?\r
+> > > \r
+> > > Hmm, that might be nicer, I'm not 100% sure.\r
+> > > \r
+> > > I wouldn't say it's mandatory for a patch like this (and I'd say other\r
+> > > peoples views on what's easy to review are at least as important as mine\r
+> > > here).\r
+> > \r
+> > Each patch should be valid in the repository without any following\r
+> > patches (preceding are obviously okay). Incorrect indentation would\r
+> > disqualify a patch from being 'valid', so it shouldn't be accepted.\r
+> \r
+> +1.\r
+> \r
+> Indentation corrections should always be part of the same patch as\r
+> the change(s) that invalidated the indentation in the first place.\r
+> \r
+> Spotting the *actual* (non-indentation) changes is a non-issue\r
+> when using `diff-refine-hunk' (or a wrapper thereof [1]).\r
+> \r
+\r
+Must... resist... getting... into... this...\r