Re: [PATCH 0/3] Use global keymap for pick entry.

diff --git a/9a/f78dafbd53496f069d30e683feba4268f438d7 b/9a/f78dafbd53496f069d30e683feba4268f438d7
new file mode 100644 (file)
index 0000000..ef1789f
--- /dev/null
+++ b/9a/f78dafbd53496f069d30e683feba4268f438d7
@@ -0,0 +1,91 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5A317431FAF\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:31:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id sgHx58zvgFEu for <notmuch@notmuchmail.org>;\r
+       Mon, 16 Sep 2013 13:31:33 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 985F3431FAE\r
+       for <notmuch@notmuchmail.org>; Mon, 16 Sep 2013 13:31:33 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id E1FB61000B2;\r
+       Mon, 16 Sep 2013 23:31:25 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/3] Use global keymap for pick entry.\r
+In-Reply-To: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1379255706-2418-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+86~g2d126a3 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 16 Sep 2013 23:31:25 +0300\r
+Message-ID: <m2vc20cxuq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 16 Sep 2013 20:31:41 -0000\r
+\r
+On Sun, Sep 15 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> This uses the recently added global keymap for pick entry. Adding this\r
+> showed a couple of historical anomalies: first that we don't need to\r
+> quote the keymap in define-key, and secondly that the\r
+> notmuch-pick-from-hello function is no longer needed.\r
+>\r
+> Thus we remove the superfluous quotes and we remove the unneeded\r
+> function.\r
+>\r
+> All tests pass and all key bindings still seem to work.\r
+\r
+This series LGTM. I don't fully understand this (fset 'kmap kmap)\r
+business but everywhere I looked (define-key uses the non-symbol-reference\r
+to the keymap (were there fsets or not))\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+\r
+Tomi\r
+\r
+\r
+>\r
+>\r
+> Mark Walters (3):\r
+>   contrib: pick: remove some superfluous quotes\r
+>   contrib: pick: use the new notmuch-common-keymap for pick entry\r
+>   contrib: pick: remove unused notmuch-pick-from-hello\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |   21 ++++-----------------\r
+>  1 files changed, 4 insertions(+), 17 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r