Re: [PATCH] test suite: don't consider skipped individual tests as failing

diff --git a/fb/5a186e73635a7c24bb6a6f5a857d7350ffd0bf b/fb/5a186e73635a7c24bb6a6f5a857d7350ffd0bf
new file mode 100644 (file)
index 0000000..fce27a8
--- /dev/null
+++ b/fb/5a186e73635a7c24bb6a6f5a857d7350ffd0bf
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 86BBF6DE0B7C\r
+ for <notmuch@notmuchmail.org>; Thu, 24 Sep 2015 12:54:08 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.158\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.158 tagged_above=-999 required=5 tests=[AWL=-0.238,\r
+  SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id dj4nBKrkqUws for <notmuch@notmuchmail.org>;\r
+ Thu, 24 Sep 2015 12:54:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id EFEC26DE0B64\r
+ for <notmuch@notmuchmail.org>; Thu, 24 Sep 2015 12:54:05 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id E056910008D;\r
+ Thu, 24 Sep 2015 22:54:08 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test suite: don't consider skipped individual tests as\r
+ failing\r
+In-Reply-To: <1443093210-6511-1-git-send-email-david@tethera.net>\r
+References: <1443093210-6511-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 24 Sep 2015 22:54:08 +0300\r
+Message-ID: <m27fnf4mqn.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 24 Sep 2015 19:54:08 -0000\r
+\r
+On Thu, Sep 24 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> It isn't completely clear what we want to do here, but\r
+>\r
+> 1) We currently don't fail if we skip a whole test file (mainly because\r
+> we neglect to count those skipped tests properly). This change at least\r
+> makes the two kinds of skipping consistent.\r
+>\r
+> 2) Automated build environments may have good reasons for building with\r
+> a minimal set of prereqs, and we don't want to discourage running our\r
+> test suite by breaking builds.\r
+> ---\r
+>  test/aggregate-results.sh | 2 +-\r
+>  1 file changed, 1 insertion(+), 1 deletion(-)\r
+>\r
+> diff --git a/test/aggregate-results.sh b/test/aggregate-results.sh\r
+> index b016edb..b30da44 100755\r
+> --- a/test/aggregate-results.sh\r
+> +++ b/test/aggregate-results.sh\r
+> @@ -82,7 +82,7 @@ if [ "$skipped" != "0" ]; then\r
+>      echo "$skipped $tests skipped."\r
+>  fi\r
+>  \r
+\r
+Looks OK, but I think there should be (some good) comment here informing\r
+any potential viewer that we're not checking $skipped...\r
+\r
+> -if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 -a $skipped -eq 0 ]\r
+> +if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 ]\r
+>  then\r
+>      exit 0\r
+>  else\r
+> -- \r
+> 2.5.1\r
+\r
+Tomi\r