--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2A456431FAF\r
+ for <notmuch@notmuchmail.org>; Sat, 4 May 2013 16:17:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Mvj2cv2JxEOT for <notmuch@notmuchmail.org>;\r
+ Sat, 4 May 2013 16:17:06 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 37D90431FAE\r
+ for <notmuch@notmuchmail.org>; Sat, 4 May 2013 16:17:06 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1UYlhG-0002GF-98; Sun, 05 May 2013 00:16:58 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1UYlhF-00053e-Sr; Sun, 05 May 2013 00:16:54 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH REBASE] emacs: add show view bindings to move to\r
+ previous/next thread\r
+In-Reply-To: <1367514302-30196-1-git-send-email-jani@nikula.org>\r
+References: <1367514302-30196-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 05 May 2013 00:16:52 +0100\r
+Message-ID: <87bo8q72u3.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: 04f9fab45664fd0c766aa1662950a201 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -1.8\r
+X-SpamAssassin-SpamBar: -\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -1.8 points.\r
+ Summary of the scoring: \r
+ * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\r
+ * medium trust\r
+ * [138.37.6.40 listed in list.dnswl.org]\r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * 0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 04 May 2013 23:17:11 -0000\r
+\r
+\r
+Hi\r
+\r
+This seems like a useful addition to me. I have a couple of comments and\r
+a little bikeshedding below.\r
+\r
+On Thu, 02 May 2013, Jani Nikula <jani@nikula.org> wrote:\r
+> We have most of the plumbing in place, add the bindings M-n and M-p.\r
+> ---\r
+> emacs/notmuch-show.el | 24 ++++++++++++++++++++++++\r
+> 1 file changed, 24 insertions(+)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index face2a0..7f6ea65 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -39,6 +39,7 @@\r
+> \r
+> (declare-function notmuch-call-notmuch-process "notmuch" (&rest args))\r
+> (declare-function notmuch-search-next-thread "notmuch" nil)\r
+> +(declare-function notmuch-search-previous-thread "notmuch" nil)\r
+> (declare-function notmuch-search-show-thread "notmuch" nil)\r
+> \r
+> (defcustom notmuch-message-headers '("Subject" "To" "Cc" "Date")\r
+> @@ -1267,6 +1268,8 @@ reset based on the original query."\r
+> (define-key map "P" 'notmuch-show-previous-message)\r
+> (define-key map "n" 'notmuch-show-next-open-message)\r
+> (define-key map "p" 'notmuch-show-previous-open-message)\r
+> + (define-key map (kbd "M-n") 'notmuch-show-next-thread-show)\r
+> + (define-key map (kbd "M-p") 'notmuch-show-previous-thread-show)\r
+\r
+These seem sensible bindings.\r
+\r
+> (define-key map (kbd "DEL") 'notmuch-show-rewind)\r
+> (define-key map " " 'notmuch-show-advance-and-archive)\r
+> (define-key map (kbd "M-RET") 'notmuch-show-open-or-close-all)\r
+> @@ -1839,6 +1842,27 @@ argument, hide all of the messages."\r
+> (if show-next\r
+> (notmuch-search-show-thread)))))\r
+> \r
+> +(defun notmuch-show-previous-thread (&optional show-previous)\r
+> + "Move to the next item in the search results, if any."\r
+ ^^\r
+Should be previous item.\r
+\r
+> + (interactive "P")\r
+> + (let ((parent-buffer notmuch-show-parent-buffer))\r
+> + (notmuch-kill-this-buffer)\r
+> + (when (buffer-live-p parent-buffer)\r
+> + (switch-to-buffer parent-buffer)\r
+> + (notmuch-search-previous-thread)\r
+> + (if show-previous\r
+> + (notmuch-search-show-thread)))))\r
+> +\r
+\r
+If you change this to \r
+ (if (and (notmuch-search-previous-thread) show-previous)\r
+ (notmuch-search-show-thread)))))\r
+then if you apply it to the first thread it jumps back to the search menu which is\r
+consistent with the next-thread version.\r
+\r
+I would have a slight preference for adding another optional argument \r
+notmuch-show-next-thread (&optional show-message previous)\r
+\r
+where if PREVIOUS is set then it would go back otherwise forward. But I\r
+with the duplicated version too.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+> +(defun notmuch-show-next-thread-show ()\r
+> + "Show the next thread in the search results, if any."\r
+> + (interactive)\r
+> + (notmuch-show-next-thread t))\r
+> +\r
+> +(defun notmuch-show-previous-thread-show ()\r
+> + "Show the previous thread in the search results, if any."\r
+> + (interactive)\r
+> + (notmuch-show-previous-thread t))\r
+> +\r
+> (defun notmuch-show-archive-thread (&optional unarchive)\r
+> "Archive each message in thread.\r
+> \r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff