Re: [PATCH v2 5/5] compact: provide user more information on after-compaction failures

diff --git a/d5/919c06a3334c5746c896ffce10b9e14a458e2c b/d5/919c06a3334c5746c896ffce10b9e14a458e2c
new file mode 100644 (file)
index 0000000..716d80b
--- /dev/null
+++ b/d5/919c06a3334c5746c896ffce10b9e14a458e2c
@@ -0,0 +1,76 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 133BF431FC0\r
+       for <notmuch@notmuchmail.org>; Thu, 14 Nov 2013 08:12:04 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NSzw2I2cKMFz for <notmuch@notmuchmail.org>;\r
+       Thu, 14 Nov 2013 08:11:56 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0B0C7431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 14 Nov 2013 08:11:56 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1VgzWG-0004pe-6a; Thu, 14 Nov 2013 12:11:48 -0400\r
+Received: (nullmailer pid 32333 invoked by uid 1000); Thu, 14 Nov 2013\r
+       16:11:44 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+       notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 5/5] compact: provide user more information on\r
+       after-compaction failures\r
+In-Reply-To: <871u2jnkai.fsf@nikula.org>\r
+References: <1384362167-12740-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1384362167-12740-6-git-send-email-tomi.ollila@iki.fi>\r
+       <871u2jnkai.fsf@nikula.org>\r
+User-Agent: Notmuch/0.16+164~gfcbf06a (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 14 Nov 2013 12:11:44 -0400\r
+Message-ID: <87y54rx8sf.fsf@unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 14 Nov 2013 16:12:04 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> On Wed, 13 Nov 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+>> After database has been compacted, there are steps to put the new\r
+>> database into place -- and these steps may fail. In case such\r
+>> failure happens, provide better information how to resolve it.\r
+>\r
+> I disagree with having a library spew all this information out. For each\r
+> case, I think it should be sufficient to just say what happened\r
+> (e.g. "rename a -> b failed" + strerror). I don't think a library's\r
+> error messages should be a tutorial on how to fix things.\r
+>\r
+\r
+I can live with whatever the concensus level of verbosity, but not the\r
+fprintf's; as I mentioned, for once we have a log hook.\r
+\r
+That might also somewhat comfort Jani, since the library client has the\r
+option of ignoring the spewing.\r
+\r
+d\r