Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to g_mime_init()

diff --git a/c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d b/c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d
new file mode 100644 (file)
index 0000000..3b9728d
--- /dev/null
+++ b/c8/2129f944f5d3f5d2f77b0cc9ba28e9f1f1f74d
@@ -0,0 +1,94 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 13C36431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 10:40:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id H-+Y40agq3vZ for <notmuch@notmuchmail.org>;\r
+       Wed, 11 Sep 2013 10:40:42 -0700 (PDT)\r
+Received: from mail-ea0-f179.google.com (mail-ea0-f179.google.com\r
+       [209.85.215.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B85E2431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 10:40:41 -0700 (PDT)\r
+Received: by mail-ea0-f179.google.com with SMTP id b10so4748694eae.38\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Sep 2013 10:40:40 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=OzoFLp4k296bUnYpJLWXSi47o9GRucF/CHjQyA0spC0=;\r
+       b=Ynxye6f1fngtEHvPT5mBb6JeRwsiLFPVHD43Tl7hFUxqYjmaTtIJOTHNzpYCRmbNYn\r
+       HKAdBhWajCmkGP3RPisbmjHQZUQ1ydnZMJ6QJoV5bss3ETvXNL6fqY2M2z97/mTTNz+N\r
+       3TcA40vN8YRNgAuDqN83OTB77tJhUuIE9Y8I8CgK1HDx7RGX4o4Se+ni+/LXYUHmCZyX\r
+       CndPMDYXqPneCDndPyF5tgjJHaOjGB4fmAA3t28wr+iL6XD2SFRC9XpTftR6xHn7C2mL\r
+       WS1koRPYbbxNRM5noEBYGevxMLDvPQ7JBwSE0Qg9zwsh+Rkcf6HwZXuRAhueCbEDR77X\r
+       fWig==\r
+X-Gm-Message-State:\r
+ ALoCoQnq80MzzB0EYLoS0AQCa0MOLOCtxz5SBLOoAyHxsrJr/Y7YLh7uVqn8D8qsv7sCBv0RCcvw\r
+X-Received: by 10.14.8.72 with SMTP id 48mr3927478eeq.25.1378921240464;\r
+       Wed, 11 Sep 2013 10:40:40 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.\r
+       [88.195.111.91])\r
+       by mx.google.com with ESMTPSA id a43sm42119643eep.9.1969.12.31.16.00.00\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Wed, 11 Sep 2013 10:40:39 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib/cli: pass GMIME_ENABLE_RFC2047_WORKAROUNDS to\r
+       g_mime_init()\r
+In-Reply-To: <8738pcjet4.fsf@awakening.csail.mit.edu>\r
+References: <1378839078-6298-1-git-send-email-jani@nikula.org>\r
+       <8738pcjet4.fsf@awakening.csail.mit.edu>\r
+User-Agent: Notmuch/0.16+74~g35e4af5 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 11 Sep 2013 20:40:40 +0300\r
+Message-ID: <87vc27p887.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 11 Sep 2013 17:40:48 -0000\r
+\r
+On Wed, 11 Sep 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> LGTM in principle, though I'd like to see a test of some of the\r
+> malformed RFC 2047 that this lets us decode.  Is there a summary\r
+> somewhere of exactly what these workarounds enable?\r
+\r
+Not that I know of; looking into gmime source it's mostly about encoded\r
+words without surrounding space, or space within encoded words.\r
+\r
+v2 now has known broken tests for known broken encodings...\r
+\r
+> This isn't directly related to this patch, but is there a reason we\r
+> g_mime_init in so many different places?  Both the CLI and\r
+> notmuch_database_open I can understand because the CLI also uses GMime\r
+> and should be sure it's initialized.  Maaaybe\r
+> notmuch_message_file_get_header because notmuch_message_file\r
+> theoretically independent of the database, even though I don't think\r
+> it's possible to call into it without first calling\r
+> notmuch_database_open.  But _notmuch_message_index_file?\r
+\r
+I noted the same, but decided it's another patch, another time.\r
+\r
+\r
+BR,\r
+Jani.\r