--- /dev/null
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 69760431FAF\r
+ for <notmuch@notmuchmail.org>; Mon, 20 Oct 2014 08:03:34 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id j3F1wU7dWvQC for <notmuch@notmuchmail.org>;\r
+ Mon, 20 Oct 2014 08:03:29 -0700 (PDT)\r
+Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com\r
+ [74.125.82.49]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client\r
+ certificate requested) by olra.theworths.org (Postfix) with ESMTPS id\r
+ B890F431FAE for <notmuch@notmuchmail.org>; Mon, 20 Oct 2014 08:03:28 -0700\r
+ (PDT)\r
+Received: by mail-wg0-f49.google.com with SMTP id x12so5658857wgg.8\r
+ for <notmuch@notmuchmail.org>; Mon, 20 Oct 2014 08:03:26 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+ d=1e100.net; s=20130820;\r
+ h=x-gm-message-state:from:to:cc:subject:date:message-id;\r
+ bh=xpj5MRhotBAUTILo8BGntCIp+Fn5pXuVjjeN6PxJ9bI=;\r
+ b=V5nKEtI1tqY1DNWKf/y07ZZP5aw8w16an2W+X6QxWG7o5VLkDVDvboLy2w7OB/hrAQ\r
+ HddYSf4w7wLBsjGtcIkXo8FTLux9gbl9sQ1NbqfGJNqJ8Uzmr3ESpaeKD6F5yMfThQtk\r
+ g6BQRksmVr16qOkN0PJY0S52qqUWdKqZYpgJSY5rzYo0V9z/HGfKInO73OM08TLQyE1V\r
+ 6IIAeC1Q1Jv3eKcNBHuHN6yU/NuFq2vpMtepDYJzNaGkN0cZ9olpAK8cFlUGqUf7rT/E\r
+ fKi2BUz8e6O0rwP0JMJze+ZKFWgUXdCpvaEIatIYzKfCKCnp7PNe5Dh1Mc7ZgFTHYH0c\r
+ f/lQ==\r
+X-Gm-Message-State:\r
+ ALoCoQnsdqC+ni6ude1CG59F/YtJUQ1DjO5o9016WEkEJmvE2T0BfwpFS8sG4RpDq+TFxE7C40NP\r
+X-Received: by 10.181.27.229 with SMTP id jj5mr21091026wid.64.1413817405174;\r
+ Mon, 20 Oct 2014 08:03:25 -0700 (PDT)\r
+Received: from localhost (mobile-internet-5d6ad2-138.dhcp.inet.fi.\r
+ [93.106.210.138]) by mx.google.com with ESMTPSA id\r
+ ws2sm12166358wjc.32.2014.10.20.08.03.23 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Mon, 20 Oct 2014 08:03:24 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] test: use LDFLAGS in test/Makefile.local\r
+Date: Mon, 20 Oct 2014 18:03:21 +0300\r
+Message-Id: <1413817401-6058-1-git-send-email-jani@nikula.org>\r
+X-Mailer: git-send-email 2.1.1\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 20 Oct 2014 15:03:34 -0000\r
+\r
+Apparently the test binaries are built with minimal LDFLAGS, only\r
+adding dependency specific LDFLAGS as needed. However because some of\r
+the test binaries incorporate notmuch object files, it is necessary to\r
+use the same link flags as notmuch. For example user provided\r
+CFLAGS/CXXFLAGS/LDFLAGS with -fsanitize=undefined fails to build the\r
+test binaries if the flags differ.\r
+\r
+---\r
+\r
+With this I could do\r
+\r
+CFLAGS="-fsanitize=undefined -g" CXXFLAGS="-fsanitize=undefined -g" LDFLAGS="-fsanitize=undefined -g" ./configure\r
+\r
+to try ubsan with gcc 4.9. No problems found while running make test\r
+(and it did find an UB I planted to ensure I had it all set up right).\r
+---\r
+ test/Makefile.local | 14 +++++++-------\r
+ 1 file changed, 7 insertions(+), 7 deletions(-)\r
+\r
+diff --git a/test/Makefile.local b/test/Makefile.local\r
+index a2d58fc1a1b0..2331ceb15e33 100644\r
+--- a/test/Makefile.local\r
++++ b/test/Makefile.local\r
+@@ -13,10 +13,10 @@ smtp_dummy_srcs = \\r
+ smtp_dummy_modules = $(smtp_dummy_srcs:.c=.o)\r
+ \r
+ $(dir)/arg-test: $(dir)/arg-test.o command-line-arguments.o util/libutil.a\r
+- $(call quiet,CC) $^ -o $@\r
++ $(call quiet,CC) $^ -o $@ $(LDFLAGS)\r
+ \r
+ $(dir)/hex-xcode: $(dir)/hex-xcode.o command-line-arguments.o util/libutil.a\r
+- $(call quiet,CC) $^ $(TALLOC_LDFLAGS) -o $@\r
++ $(call quiet,CC) $^ -o $@ $(LDFLAGS) $(TALLOC_LDFLAGS)\r
+ \r
+ random_corpus_deps = $(dir)/random-corpus.o $(dir)/database-test.o \\r
+ notmuch-config.o command-line-arguments.o \\r
+@@ -24,19 +24,19 @@ random_corpus_deps = $(dir)/random-corpus.o $(dir)/database-test.o \\r
+ parse-time-string/libparse-time-string.a\r
+ \r
+ $(dir)/random-corpus: $(random_corpus_deps)\r
+- $(call quiet,CXX) $(CFLAGS_FINAL) $^ -o $@ $(CONFIGURE_LDFLAGS)\r
++ $(call quiet,CXX) $^ -o $@ $(LDFLAGS) $(CONFIGURE_LDFLAGS)\r
+ \r
+ $(dir)/smtp-dummy: $(smtp_dummy_modules)\r
+- $(call quiet,CC) $^ -o $@\r
++ $(call quiet,CC) $^ -o $@ $(LDFLAGS)\r
+ \r
+ $(dir)/symbol-test: $(dir)/symbol-test.o lib/$(LINKER_NAME)\r
+- $(call quiet,CXX) $^ -o $@ -Llib -lnotmuch $(XAPIAN_LDFLAGS)\r
++ $(call quiet,CXX) $^ -o $@ $(LDFLAGS) -Llib -lnotmuch $(XAPIAN_LDFLAGS)\r
+ \r
+ $(dir)/parse-time: $(dir)/parse-time.o parse-time-string/parse-time-string.o\r
+- $(call quiet,CC) $^ -o $@\r
++ $(call quiet,CC) $^ -o $@ $(LDFLAGS)\r
+ \r
+ $(dir)/make-db-version: $(dir)/make-db-version.o\r
+- $(call quiet,CXX) $^ -o $@ $(XAPIAN_LDFLAGS)\r
++ $(call quiet,CXX) $^ -o $@ $(LDFLAGS) $(XAPIAN_LDFLAGS)\r
+ \r
+ .PHONY: test check\r
+ \r
+-- \r
+2.1.1\r
+\r
projects / notmuch-archives.git / commitdiff