--- /dev/null
+Return-Path: <tomi.ollila@nixu.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 73C09429E25\r
+ for <notmuch@notmuchmail.org>; Mon, 5 Dec 2011 03:39:40 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id vR5mipjWTMET for <notmuch@notmuchmail.org>;\r
+ Mon, 5 Dec 2011 03:39:39 -0800 (PST)\r
+Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 2E337429E21\r
+ for <notmuch@notmuchmail.org>; Mon, 5 Dec 2011 03:39:39 -0800 (PST)\r
+Received: from pps.filterd (mail-gw3 [127.0.0.1])\r
+ by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pB5BcWBM019807;\r
+ Mon, 5 Dec 2011 13:39:33 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+ by mail-gw3.nixu.fi with ESMTP id 114cs0m8kg-1\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Mon, 05 Dec 2011 13:39:33 +0200\r
+Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])\r
+ by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id\r
+ pB5BdWMk012916; Mon, 5 Dec 2011 13:39:32 +0200\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: [PATCH] make release: remove LATEST-$(PACKAGE)-*\r
+In-Reply-To: <87y5utsdys.fsf@rocinante.cs.unb.ca>\r
+References: <yf6ty5ttfs2.fsf@taco2.nixu.fi>\r
+ <87y5utsdys.fsf@rocinante.cs.unb.ca>\r
+User-Agent: Notmuch/0.10+55~gde3d46e (http://notmuchmail.org) Emacs/23.3.1\r
+ (i686-pc-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 05 Dec 2011 13:39:32 +0200\r
+Message-ID: <yf6born5jt7.fsf@taco2.nixu.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,\r
+ 1.0.211, 0.0.0000 definitions=2011-12-05_02:2011-12-04, 2011-12-05,\r
+ 1970-01-01 signatures=0\r
+X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0\r
+ ipscore=0 suspectscore=0\r
+ phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0\r
+ reason=mlx\r
+ scancount=1 engine=6.0.2-1012030000 definitions=main-1112050053\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 05 Dec 2011 11:39:40 -0000\r
+\r
+The tar file of particular package (notmuch in this case) is named\r
+as $(PACKAGE)-$(VERSION).tar.gz. Therefore the best way to remove\r
+previous link to LATEST is to remove all files beginning with\r
+LATEST-$(PACKAGE)- and not relying how $(VERSION) string is constructed.\r
+---\r
+\r
+Applies on top of id:"yf6ty5ttfs2.fsf@taco2.nixu.fi"\r
+\r
+More discussion at the end of this email.\r
+\r
+ Makefile.local | 2 +-\r
+ 1 files changed, 1 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/Makefile.local b/Makefile.local\r
+index b4faada..d699463 100644\r
+--- a/Makefile.local\r
++++ b/Makefile.local\r
+@@ -122,7 +122,7 @@ release: verify-source-tree-and-version\r
+ ifeq ($(REALLY_UPLOAD),yes)\r
+ git push origin $(VERSION)\r
+ cd releases && scp $(TAR_FILE) $(SHA1_FILE) $(GPG_FILE) $(RELEASE_HOST):$(RELEASE_DIR)\r
+- ssh $(RELEASE_HOST) "rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-[0-9]* ; ln -s $(TAR_FILE) $(RELEASE_DIR)/LATEST-$(TAR_FILE)"\r
++ ssh $(RELEASE_HOST) "rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-* ; ln -s $(TAR_FILE) $(RELEASE_DIR)/LATEST-$(TAR_FILE)"\r
+ endif\r
+ @echo "Please send a release announcement using $(PACKAGE)-$(VERSION).announce as a template."\r
+ \r
+-- \r
+1.7.7.3\r
+\r
+Subject: Re: [PATCH] have LATEST-notmuch-<version>.tar.gz on releases web page\r
+\r
+On Sat, 03 Dec 2011 10:32:43 -0800, David Bremner <david@tethera.net> wrote:\r
+> On Thu, 24 Nov 2011 22:41:01 +0200, Tomi Ollila <tomi.ollila@nixu.com> wrote:\r
+> > The notmuchmail/releases page used to have LATEST-notmuch-<version>\r
+> > to link to the latest notmuch source tarball. This is confusing on\r
+> > web page and on disk when the file has been downloaded. This change\r
+> > looks a bit inconsistent with the 'rm' command just executed before.\r
+> > $(TAR_FILE) is defined (currently) as $(PACKAGE)-$(VERSION).tar.gz;\r
+> > as long as the prefix stays $(PACKAGE)-$(VERSION) and version begins\r
+> > with a digit then this line is good in execution point of view.\r
+> \r
+> On IRC we talked about changing the rm command in this since I\r
+> bootstrapped the process by hand. Did you come to a conclusion one way\r
+> or the other?\r
+\r
+Yes. IMO Instead of rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-[0-9]*\r
+this should just be rm -f $(RELEASE_DIR)/LATEST-$(PACKAGE)-*\r
+\r
+This change and the patch in question are independent of each other\r
+as the former would fail to remove the LATEST- -file if $(VERSION)\r
+started without number in any case.\r
+\r
+I don't see anything else that could be used to make rm more consistent\r
+in case the -$(PACKAGE)-$(VERSION) is changed to -$(TAR_FILE) -- still, it\r
+would be silly to use -$(PACKAGE)-$(VERSION).tar.gz there; also this definition\r
+\r
+TAR_FILE=$(PACKAGE)-$(VERSION).tar.gz \r
+\r
+in Makefile.local looks pretty robust.\r
+\r
+> d\r
+\r
+Tomi\r
projects / notmuch-archives.git / commitdiff